chore: polish made-by-vercel badge - #85228
Open
LitoMore wants to merge 1 commit into
Open
Conversation
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
How?
Typically, a shields.io badge consists of three parts: icon, label, and message. Here is a simplest badge with
for-the-badgestyle:Here is the previously made-by-vercel badge with in colors (icon + message):
We should use the "icon + label" to avoid the wide gap between the icon and text. Here is the polished badge (icon + label):
Why?
I'm the active contributor of the https://github.com/badges/shields project. I'm also the maintainer of https://github.com/simple-icons/simple-icons (the icon provider of shields.io). So I am very sensitive to the style of this badge.
Although this is a one-line contribution PR for a documentation update, I'd like to elaborate on my reasoning for submitting it. Thanks for reading.