Fix App Router 404 with Pages Router i18n domain routing#86116
Draft
ruudk wants to merge 1 commit into
Draft
Conversation
ruudk
force-pushed
the
fix-86048
branch
2 times, most recently
from
f03c44d to
b99a1ff
Compare
When Pages Router uses domain-based i18n configuration, it was stripping locale prefixes from ALL requests, breaking App Router routes that need those prefixes for dynamic segments like [lang]. This fix detects when a path could match an App Router route with a dynamic locale segment and preserves the locale prefix for those routes while still stripping it for Pages Router routes. Changes: - Add detect-app-router-locale-route utility with route matching - Fix locale stripping in base-server, next-server, resolve-routes - Add comprehensive unit tests (29 test cases) - Add e2e reproducer test demonstrating the fix The fix allows both routers to coexist when middleware rewrites paths with locale prefixes for App Router consumption. Fixes vercel#86048
Author
|
@ijjk Hi 👋 How do I get the CI to run? |
Author
|
I don't think this is the best solution. But we still have this issue. It would be great if this could be solved. Happy to test any solution that comes along. @timneutkens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When Pages Router uses domain-based i18n configuration, it was stripping locale prefixes from ALL requests, breaking App Router routes that need those prefixes for dynamic segments like [lang].
This fix detects when a path could match an App Router route with a dynamic locale segment and preserves the locale prefix for those routes while still stripping it for Pages Router routes.
How?
The fix allows both routers to coexist when middleware rewrites paths with locale prefixes for App Router consumption.
Fixes #86048