Fix ENOBUFS errors in pr-status.js when fetching large CI logs#90654
Merged
Fix ENOBUFS errors in pr-status.js when fetching large CI logs#90654
Conversation
Replace execSync with async spawn-based execAsync for log fetching. execSync has a hard maxBuffer limit (50MB) causing ENOBUFS when CI job logs exceed that size. spawn streams data through pipes with no limit.
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **401 kB** → **401 kB** ✅ -23 B80 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
Address review feedback: use spawn(prog, args) instead of
spawn('/bin/sh', ['-c', cmd]) to avoid unnecessary shell invocation.
Collaborator
Tests Passed |
lukesandberg
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
spawnSync /bin/sh ENOBUFSerrors inscripts/pr-status.jswhen fetching large CI job logs.The script uses
execSync(which internally usesspawnSync) to fetch CI job logs viagh api .../jobs/{id}/logs.execSynchas a hardmaxBufferlimit (set to 50MB), and when CI job logs exceed that size, Node.js throws anENOBUFSerror. This causes the flaky test detection to silently fail, reporting 0 flaky tests.Before:
After:
Changes
execAsync()helper that useschild_process.spawninstead ofexecSync.spawnstreams data through pipes with no built-in buffer limit, avoidingENOBUFSentirely.getJobLogs()and the log-fetching loop ingetFlakyTests()to useexecAsyncinstead ofexec.exec()helper since they are well within the 50MB limit.Test Plan
Ran
node scripts/pr-status.js 90617against a PR with multiple failed jobs — completes successfully with no ENOBUFS errors.