[turbopack] replace regex with indexof#92023
Merged
lukesandberg merged 2 commits intocanaryfrom Mar 31, 2026
Merged
Conversation
nextjs-bot
added
created-by: Turbopack team
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Collaborator
Failing test suitesCommit: 09e9b0c | About building and testing Next.js |
Merging this PR will improve performance by 3.63%
Performance Changes
Comparing 
Footnotes
|
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
bgw
approved these changes
Mar 30, 2026
lukesandberg
force-pushed
the
regexes_are_bad_try_indexof
branch
from
dbd8a93 to
09e9b0c
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace regex-based
isJs/isCsschecks with string operations (indexOf+startsWith) to avoid regex overhead on a hot path. Extracts a sharedendsWithExtensionhelper that finds the end of the path portion (before?or#) and checks the extension without allocating substrings.