Skip to content

[turbopack] Fix deployment skew protection for component chunks#96079

Merged
sampoder merged 1 commit into
canaryfrom
sp/dpl-protection-component-chunks
Jul 22, 2026
Merged

[turbopack] Fix deployment skew protection for component chunks#96079
sampoder merged 1 commit into
canaryfrom
sp/dpl-protection-component-chunks

Conversation

@sampoder

@sampoder sampoder commented Jul 22, 2026

Copy link
Copy Markdown
Member

Noticed this bug where we were assuming chunks were plain strings, which may not always be the case given #95261. When putting together react/react#37095, I noticed this was also a spot we were missing so this fixes that.

Almost all of this diff is a regression test.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 9417350

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Stats from current PR

🔴 2 regressions, 1 improvement

Metric Canary PR Change Trend
Webpack Build Time 25.196s 25.866s 🔴 +670ms (+3%) ▁▁▁▁▁
Webpack Build Time (cached) 26.003s 26.542s 🔴 +539ms (+2%) ▁▂▁▁▁
node_modules Size 527 MB 516 MB 🟢 11.2 MB (-2%) ▁▁▁██
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 814ms 813ms ▁█▂▂▁
Cold (Ready in log) 807ms 798ms ▁█▂▁▁
Cold (First Request) 1.412s 1.375s ▁█▃▁▁
Warm (Listen) 813ms 813ms ▁█▂▁▁
Warm (Ready in log) 807ms 794ms ▁█▂▁▁
Warm (First Request) 1.392s 1.363s ▁█▂▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 813ms 813ms ▂▂▁▂▂
Cold (Ready in log) 793ms 804ms ▁▁▁▁▁
Cold (First Request) 3.544s 3.525s ▃▂▁▃▂
Warm (Listen) 811ms 813ms ▂▂▂▂▂
Warm (Ready in log) 773ms 793ms ▁▁▁▁▁
Warm (First Request) 3.424s 3.499s ▃▁▁▄▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.707s 5.641s ▁█▄▁▁
Cached Build 5.835s 5.699s ▁█▃▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 25.196s 25.866s 🔴 +670ms (+3%) ▁▁▁▁▁
Cached Build 26.003s 26.542s 🔴 +539ms (+2%) ▁▂▁▁▁
node_modules Size 527 MB 516 MB 🟢 11.2 MB (-2%) ▁▁▁██
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
03gmyxr7dukvs.js gzip 10.3 kB N/A -
040t1q17lo593.js gzip 8.77 kB N/A -
0bb0vtp8dwsez.js gzip 450 B N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB
0l0sr6gau5xjn.js gzip 3.53 kB N/A -
0nst2xc-t0y6v.js gzip 160 B N/A -
0nxqz3q165m2l.js gzip 220 B N/A -
0qr-1tnb7_hg5.js gzip 5.72 kB N/A -
0qtrl0m2m47zb.js gzip 155 B N/A -
0uilzvklme4ea.js gzip 8.76 kB N/A -
0uw_upkcpbwdp.js gzip 45.2 kB N/A -
0z0y83mfx-l-h.js gzip 10 kB N/A -
15ok8ydf274z0.js gzip 10.6 kB N/A -
16cqqcigykfea.js gzip 13.6 kB N/A -
17h18zxt1915l.js gzip 1.46 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B
1fq1h7dxad4cv.js gzip 9.44 kB N/A -
1fym-adbk_69_.js gzip 13.1 kB N/A -
1gav7nfh4y8ln.js gzip 8.76 kB N/A -
1o34vh44ndvtu.js gzip 13.2 kB N/A -
2-u463-ditelp.js gzip 156 B N/A -
23rhpy3kbs-7u.js gzip 65.6 kB N/A -
2dvqqp3zqpnnq.js gzip 160 B N/A -
2guls-_0xkbp2.js gzip 153 B N/A -
2lcep9_t56iw5.js gzip 166 B N/A -
2rypqffktcxqh.js gzip 8.69 kB N/A -
2uqsizxtehgqf.js gzip 8.79 kB N/A -
2vzktdqwbijqc.js gzip 8.74 kB N/A -
2xqu2ujc3uu8a.js gzip 71.1 kB N/A -
2ydpbosxm0bih.js gzip 156 B N/A -
2zezpu-768ip-.js gzip 155 B N/A -
32874-2qs3sy7.js gzip 155 B N/A -
3a80mp1w6p7__.js gzip 153 B N/A -
3c244akvx_-be.js gzip 8.74 kB N/A -
3dmlemitx3ef3.js gzip 2.29 kB N/A -
3i1ah-rd8gyl6.js gzip 156 B N/A -
3kxmazxf0zw6v.js gzip 156 B N/A -
3za9ke3-tiboq.js gzip 153 B N/A -
4237vdj6eyslt.js gzip 8.7 kB N/A -
44j-kzl6216_p.js gzip 7.4 kB N/A -
turbopack-0a..ub6b.js gzip 3.79 kB N/A -
turbopack-0q..obj3.js gzip 3.8 kB N/A -
turbopack-10..kg69.js gzip 3.8 kB N/A -
turbopack-13..bkpr.js gzip 3.8 kB N/A -
turbopack-15..07mf.js gzip 3.8 kB N/A -
turbopack-1c..8d9x.js gzip 3.8 kB N/A -
turbopack-1g..5cux.js gzip 3.8 kB N/A -
turbopack-1i..0hfx.js gzip 3.8 kB N/A -
turbopack-20..mf5k.js gzip 3.8 kB N/A -
turbopack-2l..5n26.js gzip 3.8 kB N/A -
turbopack-2y..j_7q.js gzip 3.8 kB N/A -
turbopack-31..2tc1.js gzip 3.82 kB N/A -
turbopack-3f..g_b7.js gzip 3.8 kB N/A -
turbopack-3r..ik36.js gzip 3.8 kB N/A -
0030hp-a_j9-y.js gzip N/A 156 B -
00tc16j5-eos9.js gzip N/A 1.46 kB -
02m7iodv32z8g.js gzip N/A 154 B -
0d7pewi7wgo4-.js gzip N/A 155 B -
0eruqpjj0h_ao.js gzip N/A 161 B -
0gaw1gmpwuwkn.js gzip N/A 8.8 kB -
0mejki6x1gy5u.js gzip N/A 160 B -
0pcox5e50zag8.js gzip N/A 65.6 kB -
1-mrm3ivjbndn.js gzip N/A 157 B -
12gwyaf8lv86s.js gzip N/A 157 B -
12zyjjmq4oad1.js gzip N/A 5.72 kB -
1k9cc4-gpa2cx.js gzip N/A 13.1 kB -
1kfiwrcr725kl.js gzip N/A 13.2 kB -
1n59uogejo81s.js gzip N/A 10.3 kB -
1npei3hlexdv3.js gzip N/A 9.99 kB -
1ssuiwj_rnpc5.js gzip N/A 8.77 kB -
1zp2ipjglr15r.js gzip N/A 166 B -
2-phc9obd3nyd.js gzip N/A 8.77 kB -
24gok_u2-8uee.js gzip N/A 153 B -
24utq57r3l1cw.js gzip N/A 8.7 kB -
2fhjq6ek3srmr.js gzip N/A 8.69 kB -
2g0t7upz_v-hf.js gzip N/A 10.6 kB -
2h5nkoal80pda.js gzip N/A 45.2 kB -
2ia9qqy99aie9.js gzip N/A 13.6 kB -
2k7havh6955t0.js gzip N/A 154 B -
2n5fp99a5xt9s.js gzip N/A 7.4 kB -
2oza28kdqvoay.js gzip N/A 8.74 kB -
2zh8-mmhujy8o.js gzip N/A 2.29 kB -
30h_m0irj-q6p.js gzip N/A 221 B -
37ejbfx1u9lpo.js gzip N/A 8.75 kB -
38c63ct4i1cy7.js gzip N/A 449 B -
3ge7xyod8yvys.js gzip N/A 154 B -
3jimpal3lvz5e.js gzip N/A 9.44 kB -
3psggucft0se9.js gzip N/A 71 kB -
3su6a4l8jbfth.js gzip N/A 3.53 kB -
3vn00s3x0zs4q.js gzip N/A 155 B -
3wb4pe4z4-aim.js gzip N/A 8.77 kB -
40ll_plfwk8s3.js gzip N/A 155 B -
turbopack-0r..9osd.js gzip N/A 3.8 kB -
turbopack-0t..5bzs.js gzip N/A 3.8 kB -
turbopack-0x..20qr.js gzip N/A 3.8 kB -
turbopack-10..78dl.js gzip N/A 3.81 kB -
turbopack-10..nxvf.js gzip N/A 3.8 kB -
turbopack-13..0wb8.js gzip N/A 3.78 kB -
turbopack-1a..ccvc.js gzip N/A 3.8 kB -
turbopack-1j..e8j8.js gzip N/A 3.8 kB -
turbopack-21..mb7z.js gzip N/A 3.8 kB -
turbopack-2g..jzua.js gzip N/A 3.8 kB -
turbopack-2k..c_qw.js gzip N/A 3.8 kB -
turbopack-3c..alqz.js gzip N/A 3.8 kB -
turbopack-3x..vw7k.js gzip N/A 3.8 kB -
turbopack-40..rxjx.js gzip N/A 3.8 kB -
Total 448 kB 448 kB ⚠️ +18 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 777 B 768 B 🟢 9 B (-1%)
Total 777 B 768 B ✅ -9 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 427 B 434 B 🔴 +7 B (+2%)
Total 427 B 434 B ⚠️ +7 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2486.HASH.js gzip 169 B N/A -
3146-HASH.js gzip 64.2 kB N/A -
39fcf99b-HASH.js gzip 62.9 kB N/A -
8443-HASH.js gzip 4.68 kB N/A -
9431-HASH.js gzip 5.62 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB
main-app-HASH.js gzip 255 B 252 B 🟢 3 B (-1%)
main-HASH.js gzip 39.7 kB 40.1 kB 🔴 +452 B (+1%)
webpack-HASH.js gzip 1.68 kB 1.68 kB
6105-HASH.js gzip N/A 5.63 kB -
764.HASH.js gzip N/A 169 B -
8898-HASH.js gzip N/A 63.6 kB -
9597-HASH.js gzip N/A 4.65 kB -
e1ccab69-HASH.js gzip N/A 62.9 kB -
Total 239 kB 239 kB ✅ -238 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 182 B
css-HASH.js gzip 335 B 335 B
dynamic-HASH.js gzip 1.8 kB 1.8 kB
edge-ssr-HASH.js gzip 255 B 254 B
head-HASH.js gzip 351 B 349 B
hooks-HASH.js gzip 384 B 384 B
image-HASH.js gzip 581 B 580 B
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.49 kB 2.49 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 313 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.96 kB 7.95 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 128 kB 128 kB
page.js gzip 285 kB 285 kB
Total 413 kB 413 kB ✅ -607 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 615 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 45.5 kB 45.2 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 47.1 kB 46.9 kB ✅ -228 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 720 B 720 B
Total 720 B 720 B
Build Cache
Canary PR Change
0.pack gzip 4.84 MB 4.81 MB 🟢 27.7 kB (-1%)
index.pack gzip 119 kB 119 kB
index.pack.old gzip 119 kB 119 kB
Total 5.08 MB 5.05 MB ✅ -27.4 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 366 kB 364 kB
app-page-exp..prod.js gzip 202 kB 201 kB
app-page-tur...dev.js gzip 365 kB 364 kB
app-page-tur..prod.js gzip 202 kB 201 kB
app-page-tur...dev.js gzip 362 kB 360 kB
app-page-tur..prod.js gzip 200 kB 199 kB
app-page.run...dev.js gzip 362 kB 361 kB
app-page.run..prod.js gzip 200 kB 199 kB
app-route-ex...dev.js gzip 81.8 kB 81.5 kB
app-route-ex..prod.js gzip 55.6 kB 55.4 kB
app-route-tu...dev.js gzip 81.8 kB 81.5 kB
app-route-tu..prod.js gzip 55.6 kB 55.4 kB
app-route-tu...dev.js gzip 81.4 kB 81.1 kB
app-route-tu..prod.js gzip 55.4 kB 55.1 kB
app-route.ru...dev.js gzip 81.4 kB 81.1 kB
app-route.ru..prod.js gzip 55.4 kB 55.1 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 45.4 kB 45.2 kB
pages-api-tu..prod.js gzip 34.1 kB 33.9 kB
pages-api.ru...dev.js gzip 45.4 kB 45.2 kB
pages-api.ru..prod.js gzip 34.1 kB 33.9 kB
pages-turbo....dev.js gzip 54.9 kB 54.6 kB
pages-turbo...prod.js gzip 39.7 kB 39.6 kB
pages.runtim...dev.js gzip 54.8 kB 54.6 kB
pages.runtim..prod.js gzip 39.7 kB 39.5 kB
server.runti..prod.js gzip 67.8 kB 67.5 kB
use-cache-pr...dev.js gzip 71.6 kB 71.4 kB
use-cache-pr...dev.js gzip 71.6 kB 71.4 kB
use-cache-pr...dev.js gzip 69.9 kB 69.7 kB
use-cache-pr...dev.js gzip 69.9 kB 69.7 kB
Total 3.51 MB 3.49 MB ✅ -15.8 kB
📝 Changed Files (29 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • pages-api-tu..ntime.dev.js
  • pages-api-tu..time.prod.js
  • pages-api.runtime.dev.js
  • pages-api.ru..time.prod.js
  • ... and 9 more
View diffs
app-page-exp..ntime.dev.js
failed to diff
app-page-exp..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page.runtime.dev.js
failed to diff
app-page.runtime.prod.js
failed to diff
app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

pages-api-tu..ntime.dev.js

Diff too large to display

pages-api-tu..time.prod.js

Diff too large to display

pages-api.runtime.dev.js

Diff too large to display

pages-api.ru..time.prod.js

Diff too large to display

pages-turbo...ntime.dev.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

use-cache-pr..ntime.dev.js

Diff too large to display

use-cache-pr..ntime.dev.js

Diff too large to display

use-cache-pr..ntime.dev.js

Diff too large to display

use-cache-pr..ntime.dev.js

Diff too large to display

📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/9417350fbb6523ecfb7b35853edbcad4446bdda0/next

Commit: 9417350

@sampoder
sampoder requested review from bgw and lukesandberg July 22, 2026 18:58

@lukesandberg lukesandberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you can just drop the test

@sampoder
sampoder force-pushed the sp/dpl-protection-component-chunks branch from c46b86d to 9417350 Compare July 22, 2026 19:56
@sampoder
sampoder enabled auto-merge (squash) July 22, 2026 19:59
@sampoder
sampoder merged commit 5b9d43b into canary Jul 22, 2026
128 checks passed
@sampoder
sampoder deleted the sp/dpl-protection-component-chunks branch July 22, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants