Turbopack: Very minor improvements for watcher loop#96103
Merged
Conversation
Contributor
Stats from current PR🟢 2 improvements
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: 95d018b |
Contributor
Tests PassedCommit: 95d018b |
bgw
force-pushed
the
bgw/minor-watcher-cleanup
branch
from
July 23, 2026 18:35
102a417 to
95d018b
Compare
bgw
commented
Jul 23, 2026
Comment on lines
+511
to
+513
| // flush the whole mpsc queue, we're about to rescan, we don't need to | ||
| // process any other update events that have already happened | ||
| while rx.try_recv().is_ok() {} |
Member
Author
There was a problem hiding this comment.
Minor perf improvement if we're forced to do a full rescan. Might be good because a rescan event already likely indicates that the system is overloaded.
| // For the rename::both, notify provides an array of paths | ||
| // in given order | ||
| if let [source, destination, ..] = &paths[..] { | ||
| if let [source, destination] = &paths[..] { |
Member
Author
There was a problem hiding this comment.
This event should always be exactly two paths.
https://docs.rs/notify/latest/notify/event/enum.RenameMode.html#variant.Both
This event should be emitted when both source and target are known. The paths should be provided in this exact order (from, to).
Contributor
There was a problem hiding this comment.
thanks, i was wondering about this in the other PR
| // but we also check other RenameModes to cover cases where notify couldn't match the | ||
| // two rename events. | ||
| EventKind::Any | EventKind::Modify(ModifyKind::Any | ModifyKind::Name(..)) => { | ||
| self.path.extend(paths.clone()); |
Member
Author
There was a problem hiding this comment.
path is already covered by path_and_children.
bgw
marked this pull request as ready for review
July 23, 2026 19:59
lukesandberg
approved these changes
Jul 23, 2026
bgw
disabled auto-merge
July 23, 2026 23:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed these things while reading through the code.