Improve root detection to handle worktrees, more workspaces & stray lockfiles - #96159
Merged
Conversation
Contributor
Stats from current PR🔴 1 regression, 3 improvements
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (2 files)Files with changes:
View diffspages-api.runtime.dev.jsDiff too large to display pages.runtime.dev.jsDiff too large to display 📎 Tarball URLCommit: 983e038 |
Contributor
Tests PassedCommit: 983e038 |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
bgw
reviewed
Jul 24, 2026
sampoder
force-pushed
the
sp/next/roots
branch
2 times, most recently
from
July 27, 2026 21:31
56befb6 to
6b8eb13
Compare
bgw
approved these changes
Jul 28, 2026
sampoder
force-pushed
the
sp/next/roots
branch
2 times, most recently
from
July 28, 2026 18:11
310ed7b to
9a84b05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watching too many files can hurt performance, and impacts how much work Turbopack is doing. See for example the conversation around #94597.
This PR handles the following four cases:
.gitfile).package.lockfiles &package-lock.jsonfiles (and equivalents using other package managers): if we spot apackage-lock.jsonfile but it has no packages or apackage-lock.jsonw/o an associatedpackage.jsonfile. We can ignore them. This handles the case of accidentally runningnpm installin any directory.workspacesfield in thepackage.jsonorlerna.jsonI would recommend using split-view to review. I also cleaned up the
warnDuplicatedLockFiles()function because it was a bit unnecessary to repeat the full message.Closes #92978