[turbopack] Treat Object.defineProperty(exports, …, { value: … }) as side-effect free - #96273
Merged
Conversation
sampoder
force-pushed
the
sp/define-property-side-effects
branch
2 times, most recently
from
July 27, 2026 21:33
c31662f to
07735a9
Compare
Contributor
Tests PassedCommit: 44fcd34 |
Contributor
Stats from current PR🔴 2 regressions
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: 44fcd34 |
bgw
approved these changes
Jul 27, 2026
…s side-effect free
…s.rs Co-authored-by: Benjamin Woodruff <benjamin.woodruff@vercel.com>
sampoder
force-pushed
the
sp/define-property-side-effects
branch
from
July 28, 2026 18:10
4b3845a to
44fcd34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat code like this:
As side-effect free. This is an extension of the work on #94293 and will allow #95718 to drop more dead requires.