Skip to content

Fix Turbopack worker URL context lookup - #96307

Merged
ztanner merged 1 commit into
canaryfrom
ztanner/fix-turbopack-worker-url-context
Jul 28, 2026
Merged

Fix Turbopack worker URL context lookup#96307
ztanner merged 1 commit into
canaryfrom
ztanner/fix-turbopack-worker-url-context

Conversation

@ztanner

@ztanner ztanner commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Preserve the original static worker request when generating the Turbopack module-context lookup, instead of passing an already-rewritten URL object.
  • Adds an e2e fixture for bare-module Worker URLs with conditional wildcard exports.

It looks like this might have regressed in #88602

Fixes #94015
Closes #94043

Verification

  • cargo check -p turbopack-ecmascript
  • HEADLESS=true pnpm test-start-turbo test/e2e/app-dir/worker-module-url/worker-module-url.test.ts
  • HEADLESS=true pnpm test-start-webpack test/e2e/app-dir/worker-module-url/worker-module-url.test.ts

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Stats from current PR

Warning

No stats were collected for Webpack because its stats job did not complete (it failed, was cancelled, or timed out). The results below only cover the bundlers that finished.

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 814ms 812ms █▂▁▁▂
Cold (Ready in log) 784ms 784ms █▂▁▁▁
Cold (First Request) 1.291s 1.290s █▂▁▁▁
Warm (Listen) 813ms 812ms █▂▁▁▂
Warm (Ready in log) 781ms 771ms █▂▁▁▁
Warm (First Request) 1.275s 1.286s █▂▁▂▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.121s 5.044s █▂▁▁▁
Cached Build 5.267s 5.275s █▃▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
node_modules Size 550 MB 550 MB ▁▁███
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
00984xh3ankve.js gzip 7.4 kB N/A -
00lv61-dw-p1s.js gzip 71.2 kB N/A -
0a-p0meqxynjz.js gzip 10.3 kB N/A -
0avtke4yefj4-.js gzip 13.1 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB
0fkgqovmj3kd_.js gzip 156 B N/A -
0pt5of3ch6d2u.js gzip 13.6 kB N/A -
0s_6le5473zon.js gzip 153 B N/A -
0utq7k-24q3k_.js gzip 157 B N/A -
0xnsdo-6y9r3k.js gzip 5.72 kB N/A -
0yi7is8u4covm.js gzip 8.77 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B
1prv-wg6jgtt2.js gzip 8.77 kB N/A -
1t47vod02e_4a.js gzip 8.75 kB N/A -
1tf1phijqlx9j.js gzip 220 B 220 B
1tw002sq5bo4l.js gzip 10 kB N/A -
1wlerik1n7zbr.js gzip 8.7 kB N/A -
2_zr4masp3rwy.js gzip 155 B N/A -
25xtago53_2xf.js gzip 160 B N/A -
2b2322zzwplhu.js gzip 161 B N/A -
2lviwqiqxm904.js gzip 3.52 kB N/A -
2pevdqjpbf3xk.js gzip 9.45 kB N/A -
2qd2anu9eizlz.js gzip 8.75 kB N/A -
2se72tcn7ulb_.js gzip 154 B N/A -
2sv39ae5_8vfj.js gzip 8.81 kB N/A -
2utx6n7w65xqa.js gzip 8.7 kB N/A -
2x2jbjxj8_k8h.js gzip 155 B N/A -
3-mgi7apkkmqn.js gzip 169 B N/A -
3-ukivglqkfeq.js gzip 8.78 kB N/A -
325xisqrylugu.js gzip 450 B N/A -
32fs4p58op4zm.js gzip 65.6 kB N/A -
367gc92a9294o.js gzip 158 B N/A -
3eswx3idwrkj8.js gzip 46.2 kB N/A -
3jc9ghvds1spf.js gzip 2.29 kB N/A -
3juwkvkgvywfe.js gzip 10.6 kB N/A -
3kbove7q58uqh.js gzip 13.2 kB N/A -
3kyroy-o6ffl5.js gzip 154 B N/A -
3md__14nrd0du.js gzip 156 B N/A -
3qn7vntp30gaj.js gzip 1.47 kB N/A -
3yz9mvl23_vys.js gzip 156 B N/A -
turbopack-00..nycg.js gzip 3.86 kB N/A -
turbopack-03..h4gn.js gzip 3.85 kB N/A -
turbopack-04..7jl6.js gzip 3.84 kB N/A -
turbopack-07..hdpt.js gzip 3.85 kB N/A -
turbopack-07..6ba4.js gzip 3.84 kB N/A -
turbopack-0a..weg2.js gzip 3.84 kB N/A -
turbopack-0a..ncn4.js gzip 3.85 kB N/A -
turbopack-0b..vyhj.js gzip 3.84 kB N/A -
turbopack-16..dn94.js gzip 3.84 kB N/A -
turbopack-1a..ymrt.js gzip 3.84 kB N/A -
turbopack-20..b45f.js gzip 3.85 kB N/A -
turbopack-2f..he3a.js gzip 3.82 kB N/A -
turbopack-3s..7_iy.js gzip 3.84 kB N/A -
turbopack-3y..s536.js gzip 3.84 kB N/A -
0_9-hrvr12n53.js gzip N/A 161 B -
030a1njeh5b77.js gzip N/A 10 kB -
04_0pje58tdal.js gzip N/A 153 B -
0762ohcfs5hmh.js gzip N/A 65.6 kB -
0ot0qt5np20h7.js gzip N/A 8.78 kB -
0t_fggm0_xxpv.js gzip N/A 156 B -
12m9rr7_7cexd.js gzip N/A 8.7 kB -
186r3y_rfvr0b.js gzip N/A 8.78 kB -
19kp1_j23-9g0.js gzip N/A 162 B -
19v97848yrjp7.js gzip N/A 8.81 kB -
1nd_0rwgz2ozk.js gzip N/A 9.45 kB -
1oi9pltr_e10m.js gzip N/A 10.6 kB -
1rd9tzqgzsz2w.js gzip N/A 8.77 kB -
1rq1g_cwv642d.js gzip N/A 10.3 kB -
1uojw_uabeg93.js gzip N/A 450 B -
1w-7lusgyl81y.js gzip N/A 8.7 kB -
1yf84zzm98oee.js gzip N/A 157 B -
21h56wdn9zddo.js gzip N/A 8.75 kB -
2fzbtehq6od5d.js gzip N/A 158 B -
2ia9jsnzvw1z_.js gzip N/A 158 B -
2lg10omv7xu14.js gzip N/A 3.52 kB -
2m7pysadpv9jx.js gzip N/A 170 B -
2ovff1533zvno.js gzip N/A 13.2 kB -
2s4z8jy0z7v93.js gzip N/A 1.46 kB -
2tbr9ffg2xryn.js gzip N/A 46.2 kB -
2w9le8joqnx61.js gzip N/A 7.41 kB -
2y6gb5bs4mnam.js gzip N/A 8.75 kB -
30-xsnotaxkq2.js gzip N/A 155 B -
341h71ln1jpl3.js gzip N/A 2.29 kB -
34ttpt_n7605h.js gzip N/A 5.72 kB -
36ckfq9o-ys-a.js gzip N/A 13.1 kB -
3cm252vtfpe45.js gzip N/A 157 B -
3duxb6r04415w.js gzip N/A 156 B -
3euhi91ylya-8.js gzip N/A 157 B -
3ux8nb4tavd-x.js gzip N/A 71.2 kB -
3vdh6_u50pu5t.js gzip N/A 13.6 kB -
3xpdobk_3xyd8.js gzip N/A 156 B -
turbopack-0_..ipuo.js gzip N/A 3.82 kB -
turbopack-0i..n_6b.js gzip N/A 3.85 kB -
turbopack-0u..57xm.js gzip N/A 3.84 kB -
turbopack-14..t3l7.js gzip N/A 3.85 kB -
turbopack-1i..1rnb.js gzip N/A 3.85 kB -
turbopack-1m..0fd7.js gzip N/A 3.85 kB -
turbopack-1o..7l0x.js gzip N/A 3.85 kB -
turbopack-1s..ysh5.js gzip N/A 3.85 kB -
turbopack-3-..zru6.js gzip N/A 3.85 kB -
turbopack-37..xvtz.js gzip N/A 3.85 kB -
turbopack-39..4wym.js gzip N/A 3.86 kB -
turbopack-3a..bncu.js gzip N/A 3.84 kB -
turbopack-3e..vk0g.js gzip N/A 3.85 kB -
turbopack-41..obw3.js gzip N/A 3.84 kB -
Total 450 kB 450 kB ⚠️ +61 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 776 B 774 B
Total 776 B 774 B ✅ -2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 432 B 436 B
Total 432 B 436 B ⚠️ +4 B

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 372 kB 372 kB
app-page-exp..prod.js gzip 205 kB 205 kB
app-page-tur...dev.js gzip 371 kB 371 kB
app-page-tur..prod.js gzip 205 kB 205 kB
app-page-tur...dev.js gzip 368 kB 368 kB
app-page-tur..prod.js gzip 203 kB 203 kB
app-page.run...dev.js gzip 368 kB 368 kB
app-page.run..prod.js gzip 203 kB 203 kB
app-route-ex...dev.js gzip 82.5 kB 82.5 kB
app-route-ex..prod.js gzip 55.9 kB 55.9 kB
app-route-tu...dev.js gzip 82.5 kB 82.5 kB
app-route-tu..prod.js gzip 55.9 kB 55.9 kB
app-route-tu...dev.js gzip 82.1 kB 82.1 kB
app-route-tu..prod.js gzip 55.7 kB 55.7 kB
app-route.ru...dev.js gzip 82.1 kB 82.1 kB
app-route.ru..prod.js gzip 55.7 kB 55.7 kB
dev-validati...dev.js gzip 132 kB 132 kB
dev-validati...dev.js gzip 132 kB 132 kB
dev-validati...dev.js gzip 130 kB 130 kB
dev-validati...dev.js gzip 130 kB 130 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 45.4 kB 45.4 kB
pages-api-tu..prod.js gzip 34.1 kB 34.1 kB
pages-api.ru...dev.js gzip 45.4 kB 45.4 kB
pages-api.ru..prod.js gzip 34.1 kB 34.1 kB
pages-turbo....dev.js gzip 54.9 kB 54.9 kB
pages-turbo...prod.js gzip 39.8 kB 39.8 kB
pages.runtim...dev.js gzip 54.9 kB 54.9 kB
pages.runtim..prod.js gzip 39.7 kB 39.7 kB
server.runti..prod.js gzip 68.3 kB 68.3 kB
use-cache-pr...dev.js gzip 72 kB 72 kB
use-cache-pr...dev.js gzip 72 kB 72 kB
use-cache-pr...dev.js gzip 70.3 kB 70.3 kB
use-cache-pr...dev.js gzip 70.3 kB 70.3 kB
Total 4.07 MB 4.07 MB
📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/6f7910b144319ae1c40befe36a61f82352cb530a/next

Commit: 6f7910b

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 6f7910b

@ztanner
ztanner force-pushed the ztanner/fix-turbopack-worker-url-context branch from a258f8b to 6f7910b Compare July 28, 2026 17:58
@ztanner
ztanner marked this pull request as ready for review July 28, 2026 18:38
@ztanner
ztanner requested a review from bgw July 28, 2026 18:39
@bgw
bgw requested a review from sampoder July 28, 2026 18:40

@sampoder sampoder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, thank you for the test!

@ztanner
ztanner merged commit b368a50 into canary Jul 28, 2026
227 of 230 checks passed
@ztanner
ztanner deleted the ztanner/fix-turbopack-worker-url-context branch July 28, 2026 18:48
@mitchheddles

Copy link
Copy Markdown

Thanks Zacky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Turbopack] new Worker(new URL(..., import.meta.url)) crashes in production with 'e.indexOf is not a function' (regression in 16.2)

3 participants