Bump @types/node to 20.17.7 to fix findSourceMap type - #96321
Merged
Conversation
Contributor
Tests PassedCommit: b6f940d |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (2 files)Files with changes:
View diffspages-api-tu..ntime.dev.jsDiff too large to display pages-turbo...ntime.dev.jsDiff too large to display 📎 Tarball URLCommit: b6f940d |
gaearon
commented
Jul 29, 2026
| * @return Returns `module.SourceMap` if a source map is found, `undefined` otherwise. | ||
| */ | ||
| function findSourceMap(path: string, error?: Error): SourceMap; | ||
| function findSourceMap(path: string, error?: Error): SourceMap | undefined; |
Contributor
Author
There was a problem hiding this comment.
Note I am not patching this; this is just the upstream change.
gaearon
marked this pull request as ready for review
July 29, 2026 00:10
gaearon
changed the title
eps1lon
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96198 (comment).
Bumps the pinned
@types/nodeversion to20.17.7to get an upstream fix forfindSourceMaptype.Also regenerates the pnpm patch due to a conflict.
I upgraded by just a patch because I'm not sure if we rely on being on an old version here.
Test Plan
findSourceMapnow shows correct types.