fix: restore table copy and download actions in fullscreen mode#568
Open
aradhyacp wants to merge 5 commits into
Open
fix: restore table copy and download actions in fullscreen mode#568aradhyacp wants to merge 5 commits into
aradhyacp wants to merge 5 commits into
Conversation
Contributor
|
@aradhyacp is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the table Copy and Download controls silently failed when used from the fullscreen table view.
The fullscreen table is rendered using a React portal with a
data-streamdown="table-fullscreen"container. The copy and download actions previously located the target table by searching for the nearestdata-streamdown="table-wrapper"ancestor. Because portals break DOM ancestry, the lookup failed in fullscreen mode, causing the controls to report "Table not found" and perform no action.This change broadens the table lookup to support both inline and fullscreen table containers, restoring copy and download functionality without changing the existing behavior for inline tables.
Type of Change
Related Issues
Fixes #567
Closes #567
Related to #567
Changes Made
Testing
Test Coverage
Manually tested the copy functionality using a local React app.
How I tested it locally:
I used the following test component to verify table rendering and copying behavior:
Verified that:
Copy actions work correctly from the inline table.
Copy actions work correctly from the fullscreen table.
Download actions work correctly from the inline table.
Download actions work correctly from the fullscreen table.
Screenshots/Demos
Screen.Recording.2026-07-23.at.12.32.55.AM.mov
Checklist
pnpm changeset)Changeset
Additional Notes
This fix intentionally takes the minimal approach by supporting table lookup within both
table-wrapperandtable-fullscreencontainers.A larger architectural refactor to pass table references directly (instead of relying on DOM traversal) was considered but is outside the scope of this bug fix. The current solution restores the expected functionality while preserving the existing implementation and API.