[builders]: remove getSpawnOptions usage#14604
Conversation
🦋 Changeset detectedLatest commit: d0540f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 CLI Tarball ReadyThe Vercel CLI tarball for this PR is now available! Quick TestYou can test this PR's CLI directly by running: npx https://vercel-b0vsd32ch.vercel.sh/tarballs/vercel.tgz --helpUse in vercel.jsonTo use this CLI version in your project builds, add to your {
"build": {
"env": {
"VERCEL_CLI_VERSION": "vercel@https://vercel-b0vsd32ch.vercel.sh/tarballs/vercel.tgz"
}
}
} |
🧪 Test StrategyComparing: Strategy: Code changed outside of a package - running ALL tests Affected packages - 41 (100%)
Results
This comment is automatically generated based on the affected testing strategy |
marc-vercel
left a comment
There was a problem hiding this comment.
Code wise LGTM - Can you add in the PR what we talked privately: which change caused the previous revert and how we are avoiding the same problem now?
… runPackageJsonScript instead of being wrapped in a SpawnOptions object, causing custom environment variables to be lost Co-authored-by: LukeSheard <luke@phillips-sheard.com>
5957c76 to
0995f84
Compare
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/backends@0.0.21 ### Patch Changes - Remove getSpawnOptions ([#14604](#14604)) - Updated dependencies \[]: - @vercel/introspection@0.0.8 ## @vercel/build-utils@13.2.8 ### Patch Changes - Remove getSpawnOptions ([#14604](#14604)) ## vercel@50.3.3 ### Patch Changes - Updating validation for custom deployment ids ([#14594](#14594)) - [cli] Add validation for CRON_SECRET environment variable during build to detect invalid HTTP header characters ([#14576](#14576)) - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/build-utils@13.2.8 - @vercel/static-build@2.8.19 - @vercel/backends@0.0.21 - @vercel/hydrogen@1.3.5 - @vercel/redwood@2.4.8 - @vercel/remix-builder@5.5.8 - @vercel/next@4.15.14 - @vercel/node@5.5.20 - @vercel/elysia@0.1.19 - @vercel/express@0.1.26 - @vercel/fastify@0.1.22 - @vercel/go@3.3.0 - @vercel/h3@0.1.28 - @vercel/hono@0.2.22 - @vercel/koa@0.1.2 - @vercel/nestjs@0.2.23 - @vercel/python@6.1.6 - @vercel/ruby@2.2.4 - @vercel/rust@1.0.4 ## @vercel/client@17.2.22 ### Patch Changes - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/build-utils@13.2.8 ## @vercel/elysia@0.1.19 ### Patch Changes - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/node@5.5.20 ## @vercel/express@0.1.26 ### Patch Changes - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/node@5.5.20 ## @vercel/fastify@0.1.22 ### Patch Changes - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/node@5.5.20 ## @vercel/functions@3.3.6 ### Patch Changes - Fix `TimeoutNegativeWarning` in Node.js v24 when process runs longer than 15 minutes by ensuring minimum wait time of 100ms ([#14491](#14491)) ## @vercel/gatsby-plugin-vercel-builder@2.0.118 ### Patch Changes - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/build-utils@13.2.8 ## @vercel/h3@0.1.28 ### Patch Changes - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/node@5.5.20 ## @vercel/hono@0.2.22 ### Patch Changes - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/node@5.5.20 ## @vercel/hydrogen@1.3.5 ### Patch Changes - Remove getSpawnOptions ([#14604](#14604)) ## @vercel/koa@0.1.2 ### Patch Changes - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/node@5.5.20 ## @vercel/nestjs@0.2.23 ### Patch Changes - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/node@5.5.20 ## @vercel/next@4.15.14 ### Patch Changes - Remove getSpawnOptions ([#14604](#14604)) ## @vercel/node@5.5.20 ### Patch Changes - Remove getSpawnOptions ([#14604](#14604)) - Updated dependencies \[[`92fe2dfd81c617fb733fec95a2547024d120a408`](92fe2df)]: - @vercel/build-utils@13.2.8 ## @vercel/redwood@2.4.8 ### Patch Changes - Remove getSpawnOptions ([#14604](#14604)) ## @vercel/remix-builder@5.5.8 ### Patch Changes - Remove getSpawnOptions ([#14604](#14604)) ## @vercel/static-build@2.8.19 ### Patch Changes - Remove getSpawnOptions ([#14604](#14604)) - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.118 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Overview
This is a re-apply of #14176 without the changes to remove
getSpawnOptionsfrom thebuild-utilspackage due to the breaking changes that happened.Background
The vercel environment now populates the right tools into the toolchain when subprocess are spawned in user-space. This means that builders now no longer need to think about the toolchains they need to provision.
In this case we no longer re-create
$PATHto include the node version which is needed for the build.