Skip to content

fix(web-shared): remove unused flex-1 from attribute copy-value rows#2864

Merged
mitul-s merged 1 commit into
mainfrom
fix/attributes-row-remove-flex-1
Jul 10, 2026
Merged

fix(web-shared): remove unused flex-1 from attribute copy-value rows#2864
mitul-s merged 1 commit into
mainfrom
fix/attributes-row-remove-flex-1

Conversation

@mitul-s

@mitul-s mitul-s commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The attribute copy-value row is already right-aligned by the parent's justify-between, so flex-1 only forced the value column to stretch across leftover space.
  • Removes flex-1 from rowCopyValueVariants so values hug their content.

Test plan

  • Open a run's Attributes / Metadata sidebar and confirm copyable values render right-aligned and truncate/copy correctly.

Made with Cursor

The row is already right-aligned via the parent's justify-between, so
flex-1 was only forcing the value column to stretch. Drop it so values
hug their content.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s mitul-s requested review from a team and ijjk as code owners July 9, 2026 20:36
@changeset-bot

changeset-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4680f54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/web-shared Patch
@workflow/web Patch
@workflow/cli Patch
@workflow/nitro Patch
workflow Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/core Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/vitest Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Jul 9, 2026 8:40pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment Jul 9, 2026 8:40pm
example-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workbench-astro-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workbench-express-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workbench-fastify-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workbench-hono-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workbench-nitro-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workbench-nuxt-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workbench-sveltekit-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workbench-tanstack-start-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workbench-vite-workflow Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workflow-docs Ready Ready Preview, Comment, Open in v0 Jul 9, 2026 8:40pm
workflow-swc-playground Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workflow-tarballs Ready Ready Preview, Comment Jul 9, 2026 8:40pm
workflow-web Ready Ready Preview, Comment Jul 9, 2026 8:40pm

@mitul-s mitul-s merged commit 8b3a358 into main Jul 10, 2026
53 checks passed
@mitul-s mitul-s deleted the fix/attributes-row-remove-flex-1 branch July 10, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants