Skip to content

Animate new trace viewer zoom controls#3060

Merged
mitul-s merged 1 commit into
mainfrom
c+ms/animate-trace-zoom-buttons-4fc3
Jul 23, 2026
Merged

Animate new trace viewer zoom controls#3060
mitul-s merged 1 commit into
mainfrom
c+ms/animate-trace-zoom-buttons-4fc3

Conversation

@mitul-s

@mitul-s mitul-s commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Use the new trace viewer's existing viewport animation when zooming in or out with the timeline controls, matching the animation used when focusing a span.

How did you test your changes?

  • pnpm --filter @workflow/web-shared... build
  • pnpm --filter @workflow/web-shared exec vitest run src/components/new-trace-viewer/utils.test.ts (33 passed)
  • pnpm exec biome check packages/web-shared/src/components/new-trace-viewer/trace-viewer.tsx .changeset/smooth-timeline-zoom.md
  • pnpm changeset status --since=main
  • Full @workflow/web-shared test run: 158 passed, with the two zstd compatibility tests unable to run because this environment uses Node 22.14.0, which does not expose zlib.zstdCompressSync.

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
    • Uses a patch changeset for @workflow/web-shared.
  • 🔒 DCO sign-off passes (commit created with --signoff)
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in Web Open in Cursor 

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Mitul Shah <mitulxshah@gmail.com>
@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: cea0e42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/web-shared Patch
@workflow/web Patch
@workflow/cli Patch
@workflow/nitro Patch
workflow Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/core Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/vitest Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Jul 23, 2026 4:34am
example-nextjs-workflow-webpack Ready Ready Preview, Comment Jul 23, 2026 4:34am
example-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-astro-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-express-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-fastify-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-hono-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-nestjs-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-nitro-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-nuxt-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-sveltekit-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-tanstack-start-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workbench-vite-workflow Ready Ready Preview, Comment Jul 23, 2026 4:34am
workflow-docs Ready Ready Preview, Comment, Open in v0 Jul 23, 2026 4:34am
workflow-swc-playground Ready Ready Preview, Comment Jul 23, 2026 4:34am
workflow-tarballs Ready Ready Preview, Comment Jul 23, 2026 4:34am
workflow-web Ready Ready Preview, Comment Jul 23, 2026 4:34am

@mitul-s
mitul-s marked this pull request as ready for review July 23, 2026 15:59
@mitul-s
mitul-s requested review from a team and ijjk as code owners July 23, 2026 15:59
@mitul-s
mitul-s enabled auto-merge (squash) July 23, 2026 15:59
@mitul-s
mitul-s merged commit 45a56a3 into main Jul 23, 2026
55 checks passed
@mitul-s
mitul-s deleted the c+ms/animate-trace-zoom-buttons-4fc3 branch July 23, 2026 16:01
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 45a56a3 (AI decision).

The commit only touches packages/web-shared/src/components/new-trace-viewer/trace-viewer.tsx, and verification via git ls-tree origin/stable shows the new-trace-viewer directory does not exist on stable (only the old trace-viewer component does). The change builds on the new trace viewer's viewport animation (animateTo), which exists only on main, so there is nothing to backport.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

45a56a387d343a6a77158426aaf93d158b4c443d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants