Skip to content

Remove the legacy trace viewer in favor of NewTraceViewer - #3296

Merged
mitul-s merged 1 commit into
mainfrom
c-ms/remove-old-trace-viewer
Aug 3, 2026
Merged

Remove the legacy trace viewer in favor of NewTraceViewer#3296
mitul-s merged 1 commit into
mainfrom
c-ms/remove-old-trace-viewer

Conversation

@mitul-s

@mitul-s mitul-s commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

Deletes the old @workflow/web-shared trace viewer (trace-viewer/, WorkflowTraceViewer, RunTraceView) now that NewTraceViewer is the only consumer path.

Shared Span / SpanEvent / Trace types move to lib/trace-types (still exported from the package). Timing helpers and the CSS-module ambient declaration stay under the new viewer. README and the build script are updated accordingly. Breaking: drops the RunTraceView and WorkflowTraceViewer public exports — use NewTraceViewer.

How did you test your changes?

  • pnpm -F @workflow/web-shared typecheck (only pre-existing attribute-panel TS error remains; same on clean main)
  • pnpm -F @workflow/web-shared lint — 0 errors
  • pnpm -F @workflow/web-shared test — 154 tests passed
  • pnpm -F @workflow/web test — 97 tests passed
  • Confirmed packages/web only uses NewTraceViewer / useWorkflowTraceViewerData (data hook, unrelated)

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  • 🔒 DCO sign-off passes (run git commit --signoff on your commits)
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete

Made with Cursor

@mitul-s
mitul-s requested review from a team and ijjk as code owners August 3, 2026 18:48
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Aug 3, 2026 7:53pm
example-nextjs-workflow-webpack Ready Ready Preview Aug 3, 2026 7:53pm
example-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-astro-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-express-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-fastify-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-hono-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-nestjs-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-nitro-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-nuxt-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-sveltekit-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-tanstack-start-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workbench-vite-workflow Ready Ready Preview Aug 3, 2026 7:53pm
workflow-docs Ready Ready Preview, v0 Aug 3, 2026 7:53pm
workflow-swc-playground Ready Ready Preview Aug 3, 2026 7:53pm
workflow-tarballs Ready Ready Preview Aug 3, 2026 7:53pm
workflow-web Ready Ready Preview Aug 3, 2026 7:53pm

@changeset-bot

changeset-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 776cc74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/web-shared Major
@workflow/web Major
@workflow/cli Patch
@workflow/nitro Patch
workflow Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/core Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/vitest Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
vercel Bot temporarily deployed to Preview – workflow-docs August 3, 2026 18:48 Inactive
Drop RunTraceView and WorkflowTraceViewer, move shared Span/Trace types into lib/trace-types, and keep timing helpers under the new viewer.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: mitul-s <mitulxshah@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor
cursor Bot force-pushed the c-ms/remove-old-trace-viewer branch from b9321ae to 776cc74 Compare August 3, 2026 19:49
@mitul-s
mitul-s merged commit 951695b into main Aug 3, 2026
57 checks passed
@mitul-s
mitul-s deleted the c-ms/remove-old-trace-viewer branch August 3, 2026 20:34
@github-actions github-actions Bot mentioned this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants