fix(core): reject unsupported Hook retention inside QuickJS - #3332
fix(core): reject unsupported Hook retention inside QuickJS#3332NathanColosimo wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: d7bfda9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Workflow Benchmarkscommit Backend:
📈 STSO distribution vs main (inline / queue-hop histograms)1020 steps (inline) Cumulative STSO time: main 151952ms → this run 139824ms (Δ -12128ms, -8%) 1020 steps (queue-hop) Cumulative STSO time: main 3066ms → this run 3807ms (Δ +741ms, +24%) ℹ️ Metric definitions & methodologyThe collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: Best/P75/P90/P99 deltas compare against the most recent benchmark run on Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window) Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost 🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor ( Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the |
🧪 E2E Test Results❌ Some tests failed ❌ Failed E2E Tests💻 Local Development (1 failed)nextjs-webpack-canary-quickjs (1 failed):
📦 Local Production (1 failed)sveltekit-stable-node (1 failed):
🐘 Local Postgres (1 failed)sveltekit-stable-quickjs (1 failed):
E2E Test SummarySummary
Details by Category✅ ▲ Vercel Production
❌ 💻 Local Development
❌ 📦 Local Production
❌ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
✅ vercel-multi-region
|
1 participant
Summary
node:vmenginecreateHook()Root cause
The merged QuickJS retention fix validated World support only after the VM returned. That failed loudly for uncaught calls, but it could not match the node engine's synchronous
createHook()semantics: workflow code could not catch the error, and unsupported Hooks briefly entered the pending-operation state.QuickJS now receives the same
world.capabilitiesobject that the node engine places onWorkflowOrchestratorContext. The guest checks it before correlation IDs are generated or the Hook is registered.Follow-up to #3319.
Testing
pnpm vitest run src/runtime/quickjs-runtime.test.tspnpm --filter @workflow/core typecheckpnpm --filter @workflow/core buildpnpm --filter @workflow/core test(1,908 passed; 3 expected failures)