Backport #3381: [core] Ignore duplicate events per event class instead of failing the run - #3487
Open
github-actions[bot] wants to merge 1 commit into
Open
Backport #3381: [core] Ignore duplicate events per event class instead of failing the run#3487github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
… run (#3381) Signed-off-by: Peter Wielander <mittgfu@gmail.com>
🦋 Changeset detectedLatest commit: 7065db8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #3381 to
stable(backport job run).AI recommendation: This is a correctness fix: concurrent replays can commit inert duplicate events (
step_created/step_started/wait_created, etc.) that no consumer claims, and the runtime currently escalates that toReplayDivergenceErrorand a terminalCORRUPTED_EVENT_LOGon a run whose log is actually fine. The affected code exists onstable(packages/core/src/events-consumer.tsstill callsonUnconsumedEventon the same path, pluspackages/core/src/workflow.tsandpackages/world/src/events.ts), so maintenance-line users hit the same spurious run failures. The changeset ispatchand the only additive surface (the optionalonDuplicateEventdiagnostic callback) is internal plumbing for the fix, not a new user-facing capability; note thatstable's consumer lacks the parking/idle-gate logic, so the cherry-pick will likely need manual adaptation.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.