fix(world-postgres): make step creation atomic - #3575
Open
shin4141 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 82be579 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@shin4141 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: Shin <128954611+shin4141@users.noreply.github.com>
shin4141
force-pushed
the
codex/v42-atomic-step-created-event
branch
from
August 15, 2026 03:44
b9727fe to
82be579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
step_createdevent in one transaction@workflow/world-postgresWhy
step_createdpreviously committed theworkflow_stepsrow before attempting theworkflow_eventsinsert. If the process or database failed between those writes, replay had no creation event while the exactly-once entity claim remained. Subsequent replay could only rediscover the same conflict and leave the run wedged.This fixes the
step_createdpartial-write window reported in #3081 without changing the public event contract or expanding the repair to other event types.Root cause and impact
The entity mutation and its replay evidence used separate autocommit statements. The repair moves only this pair behind a single transaction. A failed event write now rolls the entity claim back; a successful call still returns the same step/event result and preserves dense event slots.
Checks
{ stepId: 'step_partial_write' }inworkflow_stepspackages/world-postgres/test/storage.test.ts: 141 passed against an isolated PostgreSQL 17.10 database with repository migrations@workflow/world-postgresbuild: passed@workflow/world-postgrestypecheck: passed@workflow/world-postgrespatch detectedThe repository-standard Testcontainers spec suite is left to CI because Docker is not available in the local execution environment.