refactor: stop scaffolding legacy vibe.project.yaml; fix budget salvage#258
Merged
Conversation
Every scaffold wrote both vibe.config.json (the authoritative V1 contract) and a legacy vibe.project.yaml, duplicating config in every project root. vibe.config.json is a strict superset, so the YAML is pure clutter. - Stop writing vibe.project.yaml in scaffoldSceneProject and vibe init. readProjectConfig still reads it (back-compat for existing projects). - Fix a latent bug: a legacy budget.maxUsd cap was dropped on load. Salvage it into build.maxCostUsd (which is consumed), ignoring the scaffold's maxUsd:0 default so 'no cap' doesn't become a $0 gate. - Update scaffold prose/file-lists and walkthroughs to name vibe.config.json; update tests to assert the YAML is no longer created; add project-config tests covering the legacy read + salvage. No reader removed — legacy projects keep loading.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of the scene-workspace declutter (agentic CLI UX). Approved plan phase B.
Problem
Every scaffold wrote both
vibe.config.json(the authoritative V1 contract) and a legacyvibe.project.yaml, duplicating config in every project root.vibe.config.jsonis a strict superset, so the YAML is pure clutter. Separately, a legacybudget.maxUsdcap was silently dropped on load.Change
vibe.project.yamlinscaffoldSceneProjectandvibe init.readProjectConfigstill reads it (back-compat for existing projects).budget.maxUsd→build.maxCostUsd(consumed), ignoring the scaffold'smaxUsd:0default so 'no cap' doesn't become a $0 gate.vibe.config.json; update tests to assert the YAML is no longer created; addproject-configtests for the legacy read + salvage.Verify
Build clean, lint 0, full suite green. E2E:
vibe init --type scenewritesvibe.config.json, novibe.project.yaml; a legacy project withbudget.maxUsd: 7surfacesbuild.maxCostUsd === 7; scene detection still works viavibe.config.json. pre-push gate green.No reader removed — legacy projects keep loading.