-
Notifications
You must be signed in to change notification settings - Fork 430
Migrate to Ubuntu 22.04 LTS #2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/scripts/hostsetup.sh
Outdated
| default-jdk \ | ||
| g++-9 \ | ||
| gcc-9 \ | ||
| g++-10 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctags -> exuberant-ctags
python -> python2
qt5-default -> qtbase5-dev
tangxifan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After change the clang-format-7 to clang-format-12
Need to change the clang-format in cmake modules:
| xargs -P ${CPU_COUNT} clang-format-7 -style=file -i) |
|
Since ubuntu 22.04 do not have native packages of
May consider to rework the build compatibility checks:
|
|
May need to modify the build job matrix at: vtr-verilog-to-routing/.github/workflows/test.yml Lines 363 to 370 in 99d71d9
|
|
Summary of Current Status: What Have Been Done: Latest Result: Based current situation, we think to keep CI working is first priority, then we can follow up with other PRs to clean up issue and add back some compatibility supports. |
|
Agreed. So do you recommend a merge now and fix the CI breaks shortly? |
Hi @vaughnbetz, yes we suggest to merge it since critical CIs, such as build and regression tests are passing. We just need a few follow-up PRs to fix the code format, build compatibility and update QoR for some regression tests. |
|
Merging so CI keeps working. Thanks for the hard work on this one @Tulong4Dev and @tangxifan ! |
Migrate to Ubuntu 22.04 LTS
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: