Conversation
ibc
reviewed
Feb 4, 2026
Member
ibc
left a comment
ibc
left a comment
There was a problem hiding this comment.
CI lint fails and I don't see npm scripts to build the docs (npm run docs, docs:check and docs:watch) and there is missing docs CI job and docs page integration in GH JsSIP.
This reverts commit 504f2d7.
Member
Author
|
Fixing CI.
Those scripts are already there. CI job added. As indicated in the PR description, after this PR I'll create a new release. TS migration will be started from this point, which will happen as a separate feature branch. |
ibc
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leaves JsSIP ready for the TS migration.
No API changes. After this PR is merged I'm releasing a new version, then a new branch will be created with the whole TS migration.