fix: grilling skill の参照先を更新 - #111
Merged
Merged
Conversation
外部 skill 名と配布先を grilling に統一し、GitHub の SKILL.md blob URL を取得できるようにする。関連するテストとドキュメントも更新した。\n\n検証: GOMODCACHE=/tmp/gomodcache GOCACHE=/tmp/gocache GOTOOLCHAIN=local go test ./...\n検証: make deploy-dry-run
GitHub blob URL のパス判定に path パッケージを使い、Windows でも slash 区切りの URL を正しく解析する。\n\n検証: GOMODCACHE=/tmp/gomodcache GOCACHE=/tmp/gocache GOTOOLCHAIN=local go test ./...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grilling skill の参照先更新
Summary
upstream で
grill-meからgrillingへ変更された外部 skill の名前、URL、配布先を更新します。指定された GitHub の
SKILL.mdblob URL を deploy が直接扱えるようにしました。主な変更点:
grillingに統一blob/<ref>/<path>/SKILL.mdURL に対応やったこと
external-skills.jsonの URL、tree hash、配布先を更新動作確認
GOMODCACHE=/tmp/gomodcache GOCACHE=/tmp/gocache GOTOOLCHAIN=local go test ./...GOMODCACHE=/tmp/gomodcache GOCACHE=/tmp/gocache GOTOOLCHAIN=local make deploy-dry-rungrillingを取得し、tree hash と skill 名を検証レビュー & 動作確認 チェックリスト
SKILL.mdの親ディレクトリが取得対象になることgrillingになっていること推奨テスト計画:
make deploy-dry-runでgrillingの取得元と配布先を確認するmake deploy後のSKILL.mdfrontmatter を確認するその他気になることや相談ごと
URL parser の追加的な境界条件テストは今後拡充できますが、tree URL の既存経路と今回の blob URL 経路はテスト済みです。