Add dark theme color tokens#264
Merged
Merged
Conversation
Define a complete data-theme dark palette, replace component-level color literals with semantic tokens, and document the palette and ledger token aliases. Verified with npm run typecheck and npm run build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ダークテーマのカラートークン定義
Summary
data-theme="dark"で全画面の既存カラートークンと影を切り替えられるようにし、コンポーネント CSS に残っていた直接指定色もテーマトークンへ統合します。
主な変更点:
チケットへのリンク
#214
やったこと
globals.cssに[data-theme="dark"]のトークン上書きを定義index.module.cssの色リテラルがなくなったことを確認動作確認
npm run typechecknpm run buildindex.module.cssのカラーリテラル検索レビュー & 動作確認 チェックリスト
htmlにdata-theme="dark"を付与して Dashboard、Project、Settings を確認推奨テスト計画:
html[data-theme]をdarkに設定する。その他気になることや相談ごと
テーマスイッチへの状態保存・属性設定の接続は本変更の対象外です。属性を設定する
既存または後続の機構から、このパレットを利用できます。