feat: Storybook でダークテーマを切り替え可能にする#267
Merged
Merged
Conversation
Why: - コンポーネントをライトとダークの両パレットで素早く確認できるようにするため。 What: - Storybook の Theme ツールバーとプレビュー decorator を追加した。 - テーマ確認手順を英語・日本語の UI デザイン文書に追記した。 Verification: - npm run typecheck - npm exec -- storybook build --output-dir ../../../.tmp/storybook-static
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storybook でダークテーマを切り替え可能にする
Summary
Storybook の任意の Story で、ライトとダークの両パレットを切り替えて確認できるようにします。
主な変更点:
data-theme属性へ反映チケットへのリンク
やったこと
data-theme値を復元するようにした。動作確認
npm run typechecknpm exec -- storybook build --output-dir ../../../.tmp/storybook-staticnpm run storybookで任意の Story を開き、Theme ツールバーから Light / Dark を切り替えるレビュー & 動作確認 チェックリスト
推奨テスト計画:
npm run storybookを実行する。その他気になることや相談ごと
なし。