Wire dark mode sidebar toggle#268
Merged
Merged
Conversation
Persist explicit theme choices, follow the operating system before a choice is made, and cover the behavior with component tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the dark-mode Sidebar toggle
Summary
Connect the existing Sidebar switch to layout-level theme state. An explicit
user selection is persisted locally; until then, the UI follows the operating
system color-scheme preference.
主な変更点:
dark/lightchoices undertasq.theme.チケットへのリンク
Tasq issue #215
やったこと
prefers-color-scheme.matchMediachanges update the theme in real time.動作確認
npm test(104 tests)npm run typechecknpm run buildレビュー & 動作確認 チェックリスト
推奨テスト計画:
tasq.themefrom localStorage and change the OS preference.その他気になることや相談ごと
The two-state switch intentionally does not indicate whether its current value
comes from the system preference or an explicit user selection.