feat(web): continue blocked issues from comments - #298
Merged
Conversation
Add comment-card action menus and expose the continue flow only on the latest blocker comment of a blocked issue. Generalize the reject dialog so both entry points create reviewer change requests and move the issue to ready with route-specific copy. Add Storybook states and issue-detail regression coverage.\n\nVerified with npm run typecheck and npm test (110 tests).
Automatically load remaining comment pages for blocked issues and keep blocker actions inactive until the final page is available. Cover the paginated latest-blocker selection in the issue detail regression test.\n\nVerified with npm run typecheck and the issue detail test suite.
Pause automatic blocked-comment pagination when a request error is present so a failed later page does not trigger an immediate request loop. Add regression coverage for the two-request failure boundary.\n\nVerified with npm run typecheck and 16 issue detail tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocker コメントから Change Request を作成して Issue を継続
Summary
blocked Issue の最新 blocker コメントから、Change Request を作成して Issue を ready に戻せる操作を追加します。既存 Reject の処理とモーダルを共通化し、導線ごとに表示文言を切り替えます。
主な変更点:
やったこと
reviewer固定動作確認
npm run typechecknpm test(21 files / 111 tests)git diff --check origin/main...HEADレビュー & 動作確認 チェックリスト
推奨テスト計画:
その他気になることや相談ごと
共通 ContextMenu / Dialog には、フォーカス移動・フォーカストラップ・Escape 操作などの横断的なアクセシビリティ改善余地があります。既存 Reject を含む共通課題のため、この PR のスコープ外としています。