fix(web): Issue Cardのcontext menuにアイコンを表示 - #302
Merged
Conversation
Add an optional icon slot to context menu items and use it for issue card copy and status actions. Update Storybook coverage and verify each issue action renders an SVG icon.\n\nVerified with the focused IssueCard test, TypeScript typecheck, Vite build, and Storybook build.
Preserve arbitrary ReactNode children in context menu items and assert the copy, current-status, and transition icon mappings explicitly.\n\nVerified with the focused IssueCard test and TypeScript typecheck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Cardのcontext menuにアイコンを表示
Summary
Issue Cardのcontext menuで、Storybookと実画面の双方に同じアイコン付きメニュー項目を表示します。
主な変更点:
ContextMenuItemに任意のアイコンを渡せるiconpropを追加やったこと
IconProxyを使い、コピーにはcopy、現在値にはcheck、遷移先にはcircleを表示ReactNodeを受け付ける既存のchildren契約を維持動作確認
レビュー & 動作確認 チェックリスト
推奨テスト計画:
Features/Issues/Cardと実画面を比較するその他気になることや相談ごと
なし