Fix pSee brace closure, add input validation, update docs, bump version - #40
Conversation
* Add AGENTS guidelines and repository overview (#24) * Fix typos in docs and development scripts (#22) * Use explicit logical values and operators (#23) * Add input validation (#25) * Rename list variables for clarity (#28) * Fix 'as as.numeric' wording in roxygen source and regenerate Rd Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>
* Add AGENTS guidelines and repository overview (#24) * Fix typos in docs and development scripts (#22) * Use explicit logical values and operators (#23) * Add input validation (#25) * Rename list variables for clarity (#28) * Fix 'as as.numeric' wording in roxygen source and regenerate Rd Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7538a93b30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
How can this missing brace pair be real?? A missing brace pair would mean that the function just errors out and the package cuuld not be documented, right? |
You’re right that a missing brace pair would break parsing. In this case it was a single missing inner closing brace in |
Motivation
pSee()that left the innerif (is.null(d)) ... else ...block unclosed causing incorrect message/printing behavior.pSee()to prevent misuse and follow package conventions for input assertions.head_vecandhead_dfand updating generated docs.Description
stopifnot()at the start ofpSee()validating!missing(x)and thathead_vecandhead_dfare positive, finite, whole-number numeric scalars.head_n <- head_dfso the innerelseblock ends beforemsg1is computed.R/CodeAndRoll2.Rto usehead_vecandhead_dfand synchronizeman/pSee.Rdaccordingly; regenerateNAMESPACE/manvia roxygen where possible.Development/config.Rfrom2.8.0to2.8.1.Testing
pSee()which passed.git diff --checkand repository consistency checks which reported no trailing-diff issues.roxygen2::roxygenise()but it failed becauseRscriptis not available in the environment, soman/pSee.Rdwas synchronized manually andNAMESPACEshowed no required changes.Codex Task