Declare missing deps + make sibling-package calls explicit - #55
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8da05caff0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Please resolve the following issue, From a comment above. "P1 Badge Declare dependencies in the metadata source Problem: ReadWriter and ggExpress were added only to generated DESCRIPTION; Development/config.R still omits both packages. Trigger: The next package rebuild regenerates DESCRIPTION, removes these declarations, and can leave ReadWriter::column.2.row.names() without an installed dependency. Fix: Add ReadWriter and ggExpress to the appropriate fields in Development/config.R, update the dependency source, and regenerate DESCRIPTION." Otherwise, check if we are really ready to merge this and there are no problems with this PR. |
Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>
Addressed in |
Summary
FirstCol2RowNames->ReadWriter::column.2.row.names(upgrades to the non-deprecated name), andqbarplot-> guardedggExpress::qbarplot.Stringendo::function()). No behavior change.Why
CodeAndRoll2 is meant to be a low-level, near-dependency-free package. The 2 calls in (1) only worked because ReadWriter/ggExpress happened to already be loaded elsewhere. The 71 calls in (2) already worked correctly (Stringendo is in
Depends:), but writing them explicitly makes the source of every function obvious at a glance.Scope
Only calls into CodeAndRoll2's own dependency packages were touched. External libraries and base R are untouched -- that's a separate pass.