Skip to content

Declare missing deps + make sibling-package calls explicit - #55

Merged
vertesy merged 3 commits into
mainfrom
codex-review/declare-plotting-and-readwriter-deps
Aug 29, 2026
Merged

Declare missing deps + make sibling-package calls explicit#55
vertesy merged 3 commits into
mainfrom
codex-review/declare-plotting-and-readwriter-deps

Conversation

@vertesy

@vertesy vertesy commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

  1. Fixes 2 bare calls that were missing dependencies: FirstCol2RowNames -> ReadWriter::column.2.row.names (upgrades to the non-deprecated name), and qbarplot -> guarded ggExpress::qbarplot.
  2. Makes all other 71 bare calls to Stringendo explicit (Stringendo::function()). No behavior change.

Why

CodeAndRoll2 is meant to be a low-level, near-dependency-free package. The 2 calls in (1) only worked because ReadWriter/ggExpress happened to already be loaded elsewhere. The 71 calls in (2) already worked correctly (Stringendo is in Depends:), but writing them explicitly makes the source of every function obvious at a glance.

Scope

Only calls into CodeAndRoll2's own dependency packages were touched. External libraries and base R are untouched -- that's a separate pass.

@vertesy vertesy changed the title Declare ReadWriter/ggExpress dependencies for 2 bare calls Declare missing deps + make sibling-package calls explicit Aug 28, 2026
@vertesy
vertesy marked this pull request as ready for review August 29, 2026 11:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8da05caff0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread DESCRIPTION
@vertesy

vertesy commented Aug 29, 2026

Copy link
Copy Markdown
Owner Author

@copilot

Please resolve the following issue, From a comment above.

"P1 Badge Declare dependencies in the metadata source

Problem: ReadWriter and ggExpress were added only to generated DESCRIPTION; Development/config.R still omits both packages. Trigger: The next package rebuild regenerates DESCRIPTION, removes these declarations, and can leave ReadWriter::column.2.row.names() without an installed dependency. Fix: Add ReadWriter and ggExpress to the appropriate fields in Development/config.R, update the dependency source, and regenerate DESCRIPTION."

Otherwise, check if we are really ready to merge this and there are no problems with this PR.

Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>

Copilot AI commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

@copilot

Please resolve the following issue, From a comment above.
...

Addressed in cc8b9d9: added ReadWriter to Development/config.R imports and ggExpress to suggests, kept DESCRIPTION in sync, updated the dependency snapshots, and bumped the package version to 2.8.6. I also ran metadata consistency checks, secret scanning, automated code review, and CodeQL (no analyzable code changes for CodeQL). R CMD check could not be run here because R/Rscript is not installed in the runner.

@vertesy
vertesy merged commit e80b96a into main Aug 29, 2026
@vertesy
vertesy deleted the codex-review/declare-plotting-and-readwriter-deps branch August 29, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants