Skip to content

Dev - #84

Merged
vertesy merged 4 commits into
mainfrom
dev
Sep 1, 2026
Merged

Dev#84
vertesy merged 4 commits into
mainfrom
dev

Conversation

@vertesy

@vertesy vertesy commented Sep 1, 2026

Copy link
Copy Markdown
Owner

No description provided.

Updates the package metadata to 2.9.1 and refreshes generated docs. The change also adjusts the package build script formatting and cleans up a few roxygen-generated references in the man pages.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1cfbb2517

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread man/imovingSEM.Rd Outdated
\name{imovingSEM}
\alias{imovingSEM}
\title{imovingSEM (Deprecated)}
\title{imovingSEM \link{Deprecated}}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate the deprecated titles from roxygen

  • Problem: imovingSEM now links “Deprecated” instead of displaying the deprecation label. The same regression appears in man/movingAve2.Rd:5.
  • Trigger: Help-page rendering or documentation validation uses these generated .Rd files. A later roxygen run also replaces both edits because R/CodeAndRoll2.R:3938 and R/CodeAndRoll2.R:3992 still specify (Deprecated).
  • Fix: Regenerate both .Rd files from the unchanged roxygen annotations so the titles remain plain (Deprecated) text.

AGENTS.md reference: AGENTS.md:L41-L45

Useful? React with 👍 / 👎.

@vertesy

vertesy commented Sep 1, 2026

Copy link
Copy Markdown
Owner Author

@copilot

please address:

"Regenerate the deprecated titles from roxygen

Problem: imovingSEM now links “Deprecated” instead of displaying the deprecation label. The same regression appears in man/movingAve2.Rd:5.
Trigger: Help-page rendering or documentation validation uses these generated .Rd files. A later roxygen run also replaces both edits because R/CodeAndRoll2.R:3938 and R/CodeAndRoll2.R:3992 still specify (Deprecated).
Fix: Regenerate both .Rd files from the unchanged roxygen annotations so the titles remain plain (Deprecated) text.

"

I think that CodeX might be right.

Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>

Copilot AI commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@copilot

please address:
...

Fixed in 3b1a10c: regenerated man/imovingSEM.Rd and man/movingAve2.Rd titles to plain (Deprecated) text, matching the unchanged roxygen source.

@vertesy
vertesy merged commit 64a00f3 into main Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants