Skip to content

Update aiohttp, aiohttp-socks, vcrpy; fix Base.enter_context issue (SYN-10791, SYN-11156)#4987

Merged
invisig0th merged 3 commits into
masterfrom
epiphyte/SYN-10791/aiohttp-updates
Jul 15, 2026
Merged

Update aiohttp, aiohttp-socks, vcrpy; fix Base.enter_context issue (SYN-10791, SYN-11156)#4987
invisig0th merged 3 commits into
masterfrom
epiphyte/SYN-10791/aiohttp-updates

Conversation

@vEpiphyte

@vEpiphyte vEpiphyte commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
  • Update aiohttp, aiohttp-socks, vcrpy libraries.
  • Fix an issue with Base.enter_context where the __aenter__ or __enter__ methods failing would still cause the Base to hold onto the object.
  • Fixed an undefined behavior issue in the Storm HTTP API fields support, where a missing name field wasn't well defined.
  • Fix an issue with passing the incorrect timeout object to the aiohttp.ClientSession.ws_connect() API.

Related
vertexproject/vtx-base-image#1219
vertexproject/vtx-base-image#1240

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.79%. Comparing base (590bf44) to head (4e4374d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4987   +/-   ##
=======================================
  Coverage   97.78%   97.79%           
=======================================
  Files         301      301           
  Lines       64342    64345    +3     
=======================================
+ Hits        62919    62923    +4     
+ Misses       1423     1422    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vEpiphyte
vEpiphyte marked this pull request as ready for review July 15, 2026 14:40
…as held onto if entr() failed.

- Fix an issue with the aiohttp.ClientSession.ws_connect being passed the wrong timeout value. This should have been a ClientWsTimeout object.
@vEpiphyte vEpiphyte changed the title Update aiohttp, aiohttp-socks, vcrpy (SYN-10791) Update aiohttp, aiohttp-socks, vcrpy; fix Base.enter_context issue (SYN-10791) Jul 15, 2026
@vEpiphyte vEpiphyte changed the title Update aiohttp, aiohttp-socks, vcrpy; fix Base.enter_context issue (SYN-10791) Update aiohttp, aiohttp-socks, vcrpy; fix Base.enter_context issue (SYN-10791, SYN-11156) Jul 15, 2026
@vEpiphyte vEpiphyte added bug dependencies Pull requests that update a dependency file labels Jul 15, 2026
@invisig0th
invisig0th merged commit 79b5402 into master Jul 15, 2026
6 checks passed
@invisig0th
invisig0th deleted the epiphyte/SYN-10791/aiohttp-updates branch July 15, 2026 18:53
@vEpiphyte vEpiphyte added this to the v2.248.0 milestone Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants