SYN-11164 add inet:http:request:fetch property#4989
Merged
Conversation
Add :fetch = it:exec:url to inet:http:request to link an HTTP request to the fetch or page load event which caused it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4989 +/- ##
==========================================
- Coverage 97.79% 97.79% -0.01%
==========================================
Files 301 301
Lines 64345 64345
==========================================
- Hits 62924 62923 -1
- Misses 1421 1422 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an additive
:fetchproperty to theinet:http:requestform, linking an HTTP request to the fetch / page load event which caused it. Needed for Power-Ups.inet:http:request:fetch = <it:exec:url>This is the v2 side of SYN-11164 (the v3 counterpart in synapse-enterprise uses
it:exec:fetch).Changes
:fetchtoinet:http:requestinsynapse/models/inet.py.test_http_requestsets and asserts:fetch.type: model).Jira: SYN-11164