fix duration with negative duration value#423
Merged
HarrisChu merged 3 commits intorelease-5.2from Mar 16, 2026
Merged
Conversation
HarrisChu
previously approved these changes
Mar 16, 2026
Nicole00
force-pushed
the
fix_negative_duration
branch
from
5934667 to
2337498
Compare
HarrisChu
reviewed
Mar 16, 2026
| # Extract month-based flag and duration value | ||
| is_month_based = (qword & 0x1) == 1 | ||
| duration_value = qword >> 1 | ||
| print("duration_value:", duration_value) |
Contributor
There was a problem hiding this comment.
please remove this debug print .
HarrisChu
approved these changes
Mar 16, 2026
Nicole00
added a commit
that referenced
this pull request
Mar 17, 2026
* fix duration with negative duration value * update * update
Nicole00
added a commit
that referenced
this pull request
Mar 17, 2026
* fix conflict * fix duration with negative duration value (#423) * fix duration with negative duration value * update * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.