Reduce excessive path indexing#4915
Open
adamnovak wants to merge 5 commits into
Open
Conversation
…ough indexing overlays
Member
Author
|
I think we might need to fix |
Member
Author
|
This uses vgteam/libbdsg#241 in libbdsg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg find -Q/--paths-namedis now deprecated due to its partial-Protobuf outputvg findwill now index its target paths but not other haplotype paths.PathPositionOverlayHelper.Description
This should fix cases where using the
PathPositionOverlayHelperwas making us index all haplotype paths.I'm not sure if more commands need to be patched like
vg pathsto send along the names of haplotype paths they're actually interested in, to let queries on haplotype paths work. But we've only been indexing all the paths for a few months, and before that I think the behavior before that was for those queries to mysteriously give wrong answers.