Retry on a 5 minute interval if managed upgrade is blocked my maintenance windows - #272
Merged
Merged
Conversation
Cheuk (cheukt)
approved these changes
Jul 15, 2026
Evan Dorsky (EvanDorsky)
pushed a commit
to EvanDorsky/viam-agent
that referenced
this pull request
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an edge case in agent managed upgrades where an upgrade blocked by maintenance windows wouldn't retry for at least another hour, or 24 hours by default. This could lead to a situation where machines with very restrictive maintenance windows never apply upgrades. The new behavior is to enter a 5 minute retry loop when blocked by maintenance windows until an upgrade check succeeds. It will log a warning when entering this state but not on every subsequent loop. 5 minutes was chosen arbitrarily, we can change it or make it configurable