Scope the encrypted key test to the VM - #239
Merged
Merged
Conversation
main is red. #235 added a test that uses dart:io for its ssh-keygen interoperability checks and for writing the key with restricted permissions, without the @teston('vm') marker the rest of the VM-only suites carry, so the web job #230 added fails loading it: Failed to load "test/src/ssh_key_pair_encrypt_test.dart": Unsupported operation: _Namespace Nothing about the test changes, it is only scoped. Chrome goes back to 325 passing and the VM suite is unaffected at 664.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 75.68% 75.68%
=======================================
Files 81 81
Lines 6316 6316
=======================================
Hits 4780 4780
Misses 1536 1536
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main is red. The
test-webjob has failed on every commit since #235 landed.test/src/ssh_key_pair_encrypt_test.dartimportsdart:iofor itsssh-keygeninteroperability checks and for writing the key file with restricted permissions, but it never got the@TestOn('vm')marker that the other VM-only suites carry, so the web job #230 added cannot even load it:Confirmed on
f0e44e8(the #235 merge) and reproducing on everything after it. Nothing about the test itself changes here, it is only scoped, with a comment saying why so nobody removes the marker later.Verified against the 3.13.2 SDK the runners use: Chrome back to 325 passing, VM unaffected at 664,
dart formatanddart analyze --fatal-infosclean.