feat: trip cost intelligence, cost widget, and battery history - #334
Open
raykellyjr wants to merge 7 commits into
Open
feat: trip cost intelligence, cost widget, and battery history#334raykellyjr wants to merge 7 commits into
raykellyjr wants to merge 7 commits into
Conversation
added 5 commits
July 18, 2026 02:03
Only show cost per 100 distance when every charge in the filtered trips is priced. Keep known totals visible with clearer coverage notes, including when charges exist but none are priced.
- TripIntelligenceCalculator surfaces per-trip standouts on top of the existing TripsSummaryCalculator: most/least efficient, cheapest and priciest per 100 km/mi (Complete cost-coverage only), longest, biggest charging-overhead share, plus ensemble energy gap and average charging minutes per trip. - New IntelligenceCard on the Trips screen renders those highlights under the summary card; tapping a trip-backed row opens the trip. - New BatteryHealthSnapshot Room entity + DAO records the max-range figure every time the Battery screen loads, debounced to at most once per day per car and pruned to 90 rows. - Room migration 12 -> 13 adds the snapshots table; DatabaseModule provides the new DAO to Hilt consumers. - BatteryScreen renders a max-range trend using OptimizedLineChart once at least two snapshots exist, with 5 X labels and a tap tooltip per the project chart rules. - Full set of strings localized across en/it/es/ca/de/zh and the changelog entry updated.
- CostAnalyticsCalculator turns a range of ChargeSummary rows + total distance into an honest set of cost metrics: known cost, cost/100 distance (Complete coverage only), avg cost/kWh, energy added, and missing/free session counts. Reuses TripCostCoverage semantics. - CostAnalyticsRepository loads charges + distance from Room using the new ChargeSummaryDao.getInRange query, and stitches in the user's currency + unit-of-length from SettingsDataStore. All work happens on Dispatchers.IO and never touches the API. - CostAnalyticsScreen (Material3, car palette) shows range chips (7/30/90/all-time), a headline card with the cost, energy and distance figures, and a coverage card that explains partial or missing pricing. Reachable from the dashboard via a new "Costs" nav button. - CostSummaryWidget is a read-only Glance widget that mirrors the same numbers on the home screen with 7/30/90-day ranges, configurable per car. All formatting happens in the worker; the widget itself only renders preformatted strings and never talks to TeslaMate. - CostSummaryWidgetUpdateWorker owns DB access + formatting; scheduled by the receiver on install (periodic 6h) and by DataSyncWorker after each successful sync so widgets refresh with the freshest cache. - SettingsDataStore caches teslamate_units.unit_of_length under a new key; DashboardViewModel and SettingsViewModel update the cache when they fetch global settings so widgets can format distances offline. - MainActivity honours EXTRA_SKIP_CAR_WIDGET_UPDATE so tapping the cost widget does not schedule an unrelated car-status refresh. - New DAO queries for cost coverage: countWithCostInRange, countMissingCostInRange, countZeroCostInRange, getInRange. - Unit tests cover the calculator's complete/partial/missing/zero-cost cases, the widget formatter's coverage semantics, and the widget's date-range helper.
Document the read-only widget stack and Room v13 battery history cache so contributors know where cost/trip intelligence lives.
This was referenced Jul 18, 2026
Use cached TeslaMate unit-of-length as a Cost Analytics fallback, refresh units from global settings in the cost widget worker, and update the cost widget after summary sync even when detail sync retries.
Author
Review + polish pass completeSelf-reviewed and pushed follow-up fixes:
Local verification: CI note: GitHub Actions shows |
4 tasks
Cache unit-of-length during summary sync and stop live-fetching TeslaMate units in the cost widget/worker so Room values and labels cannot drift after a unit change.
Author
|
Final correctness pass: cost widget/screen now label Room data using the unit cached at summary-sync time only (no live settings fetch during widget update). Ready for workflow approval. |
Author
|
Hello, these are ready for review. GitHub has the fork stuck on "action_required" (I'm a first-time contributor). Could you approve the workflows on this pull PR and then merge? Suggested order is to merge 334 and then 332. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major read-only analytics leap for MateDroid — deeper use of owned TeslaMate data for trips, charging costs, and battery health. No vehicle commands.
Trip intelligence
Cost intelligence
Battery health
Notes
Test plan
./gradlew :app:testDebugUnitTest./gradlew :app:lintDebug