Remove legacy search test - #100
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5ae3a6a8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def setup_function(): | ||
| search_module._RESPONSE_WARNING_EMITTED.clear() | ||
|
|
||
|
|
There was a problem hiding this comment.
Removing this test file leaves the public Video.search/Collection.search routing behavior untested: after this deletion, rg "legacy_search|search/v2|rerank|stitch" tests finds no remaining coverage, while the SDK docs still advertise that legacy options such as stitch, rerank, and rerank_params are routed to the legacy endpoint. Without an equivalent test, a future change can silently send those existing calls to /search/v2 or drop the legacy payload options, breaking users who rely on the compatibility path.
Useful? React with 👍 / 👎.
1 participant
No description provided.