Skip to content

chore(package): fix security vulnerabilities in dependencies#1603

Open
Jerricho93 wants to merge 1 commit into
videojs:mainfrom
Jerricho93:fix/security-vulnerabilities
Open

chore(package): fix security vulnerabilities in dependencies#1603
Jerricho93 wants to merge 1 commit into
videojs:mainfrom
Jerricho93:fix/security-vulnerabilities

Conversation

@Jerricho93
Copy link
Copy Markdown

@Jerricho93 Jerricho93 commented May 19, 2026

Note: This PR should be merged after the following upstream PRs are merged and published to npm, so the lockfile picks up the fixed versions:

Description

Fix security vulnerabilities in npm dependencies.

  • rollup was on a range that included versions <=2.79.2, which are affected by a DOM clobbering vulnerability (high severity). Bumped to ^2.80.0.
  • jsdoc was on ^3.6.11 which pulls in marked@0.x via transitive dependencies, affected by a high-severity ReDoS vulnerability. Bumped to ^4.0.5.
  • Added overrides to force patched versions of several vulnerable transitive dependencies: @xmldom/xmldom (critical, via mpd-parser), serialize-javascript (high), underscore (high), handlebars (high), minimatch (high), braces (high), ansi-regex (high), cross-spawn (high), semver (high), axios (high, via water-plant-uml), path-to-regexp (high), and moderate-severity trim, trim-newlines.

Specific Changes proposed

  • Bump rollup from ^2.36.1 to ^2.80.0 in devDependencies
  • Bump jsdoc from ^3.6.11 to ^4.0.5 in devDependencies
  • Add overrides block to force patched versions of vulnerable transitive dependencies

Requirements Checklist

  • Feature implemented / Bug fixed
  • Unit Tests updated or fixed
  • Docs/guides updated
  • Reviewed by Two Core Contributors

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant