Skip to content

chore(package): replace access-sniff with pa11y and fix security vulnerabilities#9180

Draft
Jerricho93 wants to merge 1 commit into
videojs:mainfrom
Jerricho93:fix/vulnerabilities
Draft

chore(package): replace access-sniff with pa11y and fix security vulnerabilities#9180
Jerricho93 wants to merge 1 commit into
videojs:mainfrom
Jerricho93:fix/vulnerabilities

Conversation

@Jerricho93
Copy link
Copy Markdown

@Jerricho93 Jerricho93 commented May 19, 2026

Note: This PR should be merged after all upstream dependency PRs are merged and published to npm.

Build toolchain (merge these first):

Runtime dependencies (merge after toolchain):

Description

Fix security vulnerabilities and replace deprecated access-sniff with pa11y.

access-sniff pulled in critical/high vulnerabilities through axios, jsdom, and phantomjs-prebuilt. Replaced with pa11y. Also: webpack ^1.15.0^5.106.0 (critical vulns), semver ^5.7.0^7.5.4 (ReDoS), plus an overrides block for remaining transitive vulnerabilities.

Specific Changes proposed

  • Remove access-sniff; add pa11y ^9.1.1 + build/test-pa11y.js
  • Bump webpack to ^5.106.0; add webpack-cli ^5.1.4; update build:test:webpack script
  • Bump semver to ^7.5.4; add overrides block

Requirements Checklist

  • Feature implemented / Bug fixed
  • Has no DOM changes which impact accessibility
  • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

…erabilities

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Jerricho93 Jerricho93 marked this pull request as draft May 19, 2026 19:16
@Jerricho93
Copy link
Copy Markdown
Author

@mister-ben I've opened a series of PRs to fix security vulnerabilities across the videojs org dependencies. Before this one can be merged, the upstream PRs listed in the description need to be reviewed, merged, and published to npm first (in roughly that order, since some depend on others).

Once those are all released, I'll update the lockfile here and mark this ready for review.

Would you be able to take a look at those PRs when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant