feat: add compound html timerange component - #14
Merged
Merged
Conversation
cjpillsbury
reviewed
Sep 16, 2025
| state: TState | ||
| ) => React.ReactElement; | ||
|
|
||
| const Context = React.createContext<any | null>(null); |
Collaborator
There was a problem hiding this comment.
non-blocking: If there's an easy way to make this optional, that would be 👌. Feel free to e.g. change the args into an "options-style object" if that makes things easier.
Collaborator
Author
There was a problem hiding this comment.
cool yes, that a nice optimization. I'll leave it for a next iteration.
cjpillsbury
reviewed
Sep 16, 2025
|
|
||
| export const useTimeRangeTrackProps = (props: React.PropsWithChildren<{ [k: string]: any }>) => { | ||
| const { setTrackRef } = useTimeRangeRootContext(); | ||
| export const useTimeRangeTrackProps = (props: React.PropsWithChildren<{ [k: string]: any }>, context: any) => { |
Collaborator
There was a problem hiding this comment.
question(non-blocking) - is this "context" or the context's "value"?
Collaborator
Author
There was a problem hiding this comment.
the context value
const context = React.useContext(Context);
bad naming on my part
luwes
changed the title
luwes
marked this pull request as ready for review
September 18, 2025 15:57
Merged
Merged
cjpillsbury
added a commit
that referenced
this pull request
May 21, 2026
Adds the network-resilience feature doc at coarse depth as the cluster G foundation. Borderline / response-error handling: retry/backoff, error classification, VRLT-aware response handling, playback-token- expiry refresh, customer-policy hooks. Tier 1 / Tier 2 framing with Naive vs Full depth distinctions per phase. Reframes cluster G: previously framed as "selection resilience" with multi-CDN as the primary feature. The cluster splits along two axes now — response-error handling (network-resilience covers this) and selection-side resilience (multi-cdn-failover / content-steering as sister consumer features yet to land). Absorbs: - selection-retry-backoff candidate (now Tier 1 phase: Generic retry with backoff + Error classification + retry budget/circuit-breaker in Tier 2) - Notion epic #12 VRLT (Viewer Rate Limiting Token) as Tier 2 phase - Notion epic #14 Playback Token Expiry as Tier 2 phase Six phases total: Generic retry (Tier 1) + Error classification (Tier 1) + Retry budget/circuit breaker (Tier 2) + VRLT-aware response (Tier 2) + Playback-token-expiry (Tier 2) + Customer-policy hooks (Tier 2). Cross-cutting impact captures: createTrackedFetch composition (sibling wrapper vs extension), bandwidth-sample exclusion for retry attempts, retry-policy slot vs per-site config, composition with multi-cdn-failover (retry vs rotation boundary), circuit-breaker state ownership, token-refresh hook convergence with DRM license- refresh, per-fetch-site config (manifest/segment/license/text- segment), live-stream reload-loop retry semantics. Open questions left explicit: retry-policy slot, default retry counts per site, VRLT detection signature shape, token-refresh hook, bandwidth-sample filtering, circuit-breaker ownership, composition order with multi-cdn-failover, retry-exhaustion error surfacing, composition with DRM, composition with content-steering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cjpillsbury
added a commit
that referenced
this pull request
May 21, 2026
Adds the network-resilience feature doc at coarse depth as the cluster G foundation. Borderline / response-error handling: retry/backoff, error classification, VRLT-aware response handling, playback-token- expiry refresh, customer-policy hooks. Tier 1 / Tier 2 framing with Naive vs Full depth distinctions per phase. Reframes cluster G: previously framed as "selection resilience" with multi-CDN as the primary feature. The cluster splits along two axes now — response-error handling (network-resilience covers this) and selection-side resilience (multi-cdn-failover / content-steering as sister consumer features yet to land). Absorbs: - selection-retry-backoff candidate (now Tier 1 phase: Generic retry with backoff + Error classification + retry budget/circuit-breaker in Tier 2) - Notion epic #12 VRLT (Viewer Rate Limiting Token) as Tier 2 phase - Notion epic #14 Playback Token Expiry as Tier 2 phase Six phases total: Generic retry (Tier 1) + Error classification (Tier 1) + Retry budget/circuit breaker (Tier 2) + VRLT-aware response (Tier 2) + Playback-token-expiry (Tier 2) + Customer-policy hooks (Tier 2). Cross-cutting impact captures: createTrackedFetch composition (sibling wrapper vs extension), bandwidth-sample exclusion for retry attempts, retry-policy slot vs per-site config, composition with multi-cdn-failover (retry vs rotation boundary), circuit-breaker state ownership, token-refresh hook convergence with DRM license- refresh, per-fetch-site config (manifest/segment/license/text- segment), live-stream reload-loop retry semantics. Open questions left explicit: retry-policy slot, default retry counts per site, VRLT detection signature shape, token-refresh hook, bandwidth-sample filtering, circuit-breaker ownership, composition order with multi-cdn-failover, retry-exhaustion error surfacing, composition with DRM, composition with content-steering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.