fix(sandbox): prevent css causing full app refresh - #1869
Merged
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (39)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (33)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (68)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (11)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sandbox app was thrashing on CSS changes. This fixes that and also fixes HMR for CSS changes, which previously refreshed the whole app, ewww.
Note
Low Risk
Dev/build-time CSS copy behavior only; low production impact, with minor risk if polling or skip-write logic misses updates in edge cases.
Overview
Fixes sandbox CSS thrashing and full-page reloads on style edits by changing how package CSS is emitted during watch builds.
copyCssPlugingainsinlineandrebuildflags, skips writing when output is unchanged, and whenrebuild: falsewith--watchit stops registering CSS viaaddWatchFile(which was forcing full rebundles). Instead it polls source CSS and updatesdistonly when files change. AcloseWatcherhook clears the poll interval.@videojs/reactand@videojs/skinswire the plugin withrebuild: false; skins drops tsdown’scopy+ local watch plugin in favor ofinline: falseon the shared plugin. Rootdev:sandboxnow builds sandbox dependencies once, then runsturbo devwith--onlyon the sandbox app.Reviewed by Cursor Bugbot for commit 48c2d46. Bugbot is set up for automated code reviews on this repo. Configure here.