fix(i18n): preserve registered translation overrides - #2354
Merged
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — 15 small size changes
Presets (7)
Media (20)
Players (5)
Skins (29)
UI Components (43)
⚛️ @videojs/react — no changesPresets (7)
Media (23)
Players (5)
Skins (26)
UI Components (37)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/media — no changesEntries (20)
📦 @videojs/spf — no changesEntries (10)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
decepulis
approved these changes
Aug 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure translations registered by applications remain authoritative over lazy-loaded built-in locale packs. This keeps regional overrides such as
de-DEeffective and lets mounted providers reflect registry updates consistently.Changes
Testing
pnpm -F @videojs/html test src/i18n/tests/create-i18n.test.tspnpm -F @videojs/react test src/i18n/tests/create-i18n.test.tsxpnpm exec biome check packages/html/src/i18n/provider-mixin.ts packages/html/src/i18n/tests/create-i18n.test.ts packages/react/src/i18n/use-merged-translations.ts packages/react/src/i18n/tests/create-i18n.test.tsxgit diff --checkpnpm typecheck(blocked by existing SPFMediaPlaylistMetadataerrors inpackages/spf; no i18n type errors)Note
Low Risk
Small merge-order fix in i18n layering only; no auth, data, or API surface changes. Behavior change is limited to which translation source wins on key collisions.
Overview
Registered app translations now win over lazy-loaded built-in locale packs in both HTML and React i18n providers. Regional overrides such as
de-DEstay effective when a parent pack likedeloads later, and registry updates after mount still apply.React still applies the provider
translationsprop last. Tests cover regional override precedence and a locale-switch case that now expects the registered string rather than the lazy overlay.Reviewed by Cursor Bugbot for commit 0523b97. Bugbot is set up for automated code reviews on this repo. Configure here.