Skip to content

refactor(store): use undefined instead of null for void-input placeholder#322

Merged
mihar-22 merged 1 commit intomainfrom
refactor/request-undefined-placeholder
Jan 22, 2026
Merged

refactor(store): use undefined instead of null for void-input placeholder#322
mihar-22 merged 1 commit intomainfrom
refactor/request-undefined-placeholder

Conversation

@mihar-22
Copy link
Copy Markdown
Member

Summary

  • Change type signature for void-input requests from (input?: null, meta?) to (input?: undefined, meta?) for more idiomatic JS/TS usage
  • Also handle undefined input type in addition to void

Changes

File Change
request.ts Update ResolveRequestHandler type
store.test.ts Update test to use undefined
README.md Update examples

Usage

// Before
store.request.play(null, { source: 'user' });

// After
store.request.play(undefined, { source: 'user' });

…lder

Change the type signature for void-input requests from `(input?: null, meta?)`
to `(input?: undefined, meta?)` for more idiomatic JS/TS usage.

Also handle `undefined` input type in addition to `void`.
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
vjs-10-website Skipped Skipped Jan 22, 2026 11:16am

Request Review

@mihar-22 mihar-22 merged commit 730dd43 into main Jan 22, 2026
4 checks passed
@mihar-22 mihar-22 deleted the refactor/request-undefined-placeholder branch January 22, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant