Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/store/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,12 @@ await store.request.seek(30);
Every request accepts optional metadata as the last argument.

```ts
store.request.play(null, { source: 'user', reason: 'play-button' });
store.request.play(undefined, { source: 'user', reason: 'play-button' });
store.request.seek(30, { source: 'user', reason: 'slider-scrub' });
store.request.pause(null, { source: 'system', reason: 'ad-start' });
store.request.pause(undefined, { source: 'system', reason: 'ad-start' });

// Infer metadata from DOM event
store.request.play(null, createRequestMetaFromEvent(clickEvent)); // MouseEvent
store.request.play(undefined, createRequestMetaFromEvent(clickEvent)); // MouseEvent
```

Handlers receive metadata:
Expand Down
4 changes: 2 additions & 2 deletions packages/store/src/core/request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ export type ResolveRequestMap<Requests> = {

export type ResolveRequestHandler<R>
= R extends Request<infer I, infer O>
? [I] extends [void]
? (input?: null, meta?: RequestMetaInit) => Promise<O>
? [I] extends [void | undefined]
? (input?: undefined, meta?: RequestMetaInit) => Promise<O>
: (input: I, meta?: RequestMetaInit) => Promise<O>
: never;

Expand Down
2 changes: 1 addition & 1 deletion packages/store/src/core/tests/store.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ describe('store', () => {

store.attach(new MockMedia());

await store.request.action(null, {
await store.request.action(undefined, {
source: 'user',
reason: 'test',
});
Expand Down