#249: ten stale claims, and a guard so the worst class stops recurring - #258
Merged
Conversation
…ss stops recurring All ten re-verified against the tree as it stands, not taken from the issue. TWO GARBLED EDIT-SPLICES in tests/test_env_declaration.py — a `#:` block opening mid-sentence with its antecedent gone and a stranded trailing line, and a docstring reading "not our business, which is an IGNORED table disappearing is silent". Both were the residue of deleting a sentence from the middle of a paragraph. TWO WORKING-TREE CLAIMS, in run_pytest.yml and G7's docstring, describing readers that were moved to the sibling's `main` on 2026-08-11. Zero read the working tree now. ADR-017's "None of those three is in place yet" is DELETED rather than updated, which is #250's §7b applied on its first day: an ADR states a decision, not the current state of the code. Updating it would have been the churn §7b exists to stop. ADR-016's `public?` column keeps its honest paragraph and gains the trigger and owner ADR-014 §4 requires — re-read it when a repository changes visibility or CI fails to check one out — plus the reason it is deliberately not machine-checked: verifying it means a network call from a suite that makes none, and the failure it would catch already fails loudly at the checkout step. THE þing MIS-CITATION IS CORRECTED AT ALL THREE SITES. The ruling forbidding integration tests against the production Appwrite project is þing-01 D2, not þing-02 D2, it is CONDITIONAL, and it GRANTS read-only preflight validation. Citing the wrong verdict is how a permission read as a prohibition for weeks — and one of the two corrected sites was arguing that a preflight could not be built. `[test_environment]` stays IGNORED, but its comment no longer says "a fact about the platform, not about this package". It is the clause that says which live checks this package may build. Reading it mechanically waits on C-91, since its rows are bare strings. AND THE BLOB URL SHA NOW HAS A GUARD, which is the point of doing this story at all. The docstrings publish a registry URL whose sha is a third copy of the pin, and only the version was compared. That is how an annotated tag reached the pin: git peeled it, every check passed, and two PUBLIC modules published a link returning 404 three lines above the sentence "a pinned URL does not rot". Third time this class has bitten. Mutation-proven by desynchronising the URL from the constant. Suite 417 passed / 1 skipped / 40 xfailed, ruff clean. Closes #249. Epic #241. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249. Gate 2 of epic #241. All ten re-verified against the tree as it stands.
The one that matters: the blob URL sha now has a guard
Both
appwrite_env.pydocstrings publish a registry blob URL whose sha is a third copy of the pin — and only the version was compared. That is how an annotated tag reached the pin: git peeled it, every check passed, and two public modules published a link returning 404 three lines above the sentence "a pinned URL does not rot".Third time this class has bitten. Mutation-proven by desynchronising the URL from the constant.
§7b applied on its first day
ADR-017's "None of those three is in place yet" is deleted, not updated — an ADR states a decision, not the current state of the code. Updating it would have been exactly the churn #250's §7b exists to stop.
ADR-016's
public?column keeps its honest paragraph and gains the trigger and owner ADR-014 §4 requires, plus the reason it is deliberately not machine-checked.The þing mis-citation, corrected at all three sites
The ruling forbidding integration tests against the production Appwrite project is þing-01 D2, not þing-02 D2. It is conditional, and it grants read-only preflight validation.
Citing the wrong verdict is how a permission read as a prohibition for weeks — and one of the corrected sites was arguing that a preflight could not be built.
The rest
Two garbled edit-splices (a
#:block opening mid-sentence, a docstring reading "not our business, which is an IGNORED table disappearing is silent"). Two working-tree claims describing readers moved to the sibling'smainon 2026-08-11 — zero read the working tree now. And[test_environment]'s comment no longer says "not about this package"; it is the clause that says which live checks this package may build.🤖 Generated with Claude Code