Skip to content

Conversation

@DavidFriant
Copy link

This commit updates the digraphs Left-Pointing Angle Bracket '</' and Right-Pointing Angle Bracket '/>' to account for the fact that the old Unicode codepoints for them (2329 and 232A, respectively) have been deprecated. As per the Miscellaneous Technical code chart, the old digraphs have been reassigned to CJK Left Angle Bracket and Right Angle Bracket (3008 and 3009) with their declarations moved to the appropriate block.

This commit also introduces the new digraphs '<[' and ']>' to represent the Mathematical Left Angle Bracket and Mathematical Right Angle Bracket (27E8 and 27E9) to replace the deprecated code points in the Technical block.

Tests have been added and, I believe, the documentation has been updated accordingly.

Note that this is the second attempt for this pull request as I closed the first due to a test failure which has now been corrected.

David Friant added 2 commits August 13, 2025 21:55
and Right-Pointing Angle Bracket '/>' to account for the fact that
the old Unicode codepoints for them (2329 and 232A, respectively)
have been deprecated. As per the Miscellaneous Technical code chart
(https://www.unicode.org/charts/PDF/U2300.pdf), the old digraphs
have been reassigned to the CJK Left Angle Bracket and Right Angle
Bracket (3008 and 3009) with their declaration moved to the
appropriate block.

This commit also introduces the new digraphs '<[' and ']>' to
represent the Mathematical Left Angle Bracket and Mathematical
Right Angle Bracket (27E8 and 27E9) to replace the deprecated code
points in the Technical block.

Tests have been added and, I believe, the documentation has been
updated accordingly.

Signed-off-by: David Friant <noemail@anonymous.com>
the previous commit when writing the test for the angle brackets
patch.

Signed-off-by: David Friant <friant@noemail.anonymous.com>
@chrisbra
Copy link
Member

Let me repeat my message from the original, now closed PR #17989

I am not a big fan of silently changing the digraph characters. That might be unexpected and it does no longer correspond to RFC1345.

So not sure we should do this, other opinions?

@DavidFriant
Copy link
Author

Re-hello,
Allow me to also copy my message from the closed pull request:

Hello, I am inclined to agree with you the silently changing digraph characters isn't ideal, but RFC1345 isn't likely to ever be updated as per Errata 4272. Without any expectation of an update, I think it is best to modernize things as best we can at least as far as properly using Unicode is concerned. Also, this conversation should likely continue on the Pull request that I haven't closed: #17990

@benknoble
Copy link
Contributor

Meta: there’s no need to close a PR because a test failed: you can push new commits that will be reflected in the PR (or—preferable in many cases IMO—force-push rewritten history with any fixes you need). It can create confusion to have to follow conversations across multiple PRs.

@DavidFriant
Copy link
Author

Meta: there’s no need to close a PR because a test failed: you can push new commits that will be reflected in the PR (or—preferable in many cases IMO—force-push rewritten history with any fixes you need). It can create confusion to have to follow conversations across multiple PRs.

Thanks! That's what I've since learned. I've been using git for years, but only recently decided to start making open source contributions, and the workflow is a bit different than what I am accustomed to. Sorry for the trouble.

More importantly, further discussion on whether or not to step away from strict adherence to RFC 1345 in favor of modernized Unicode is most welcome.

@chrisbra
Copy link
Member

We made a few adjustments to the digraphs and added some new ones, like the Rouble and Euro sign. Let's include it.

@chrisbra chrisbra closed this in c08b94b Aug 16, 2025
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 17, 2025
Problem:  Unicode has deprecated some code-points
Solution: Update the digraph tables to align with the Unicode v16
          release (David Friant)

This commit updates the digraphs Left-Pointing Angle Bracket '</'
and Right-Pointing Angle Bracket '/>' to account for the fact that
the old Unicode codepoints for them (2329 and 232A, respectively)
have been deprecated. As per the Miscellaneous Technical code chart
(https://www.unicode.org/charts/PDF/U2300.pdf), the old digraphs
have been reassigned to the CJK Left Angle Bracket and Right Angle
Bracket (3008 and 3009) with their declaration moved to the
appropriate block.

This commit also introduces the new digraphs '<[' and ']>' to
represent the Mathematical Left Angle Bracket and Mathematical
Right Angle Bracket (27E8 and 27E9) to replace the deprecated code
points in the Technical block.

Tests have been added and, I believe, the documentation has been
updated accordingly.

closes: vim/vim#17990

vim/vim@c08b94b

Co-authored-by: David Friant <friant@HPEnvyx360.friant.dev>
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Aug 17, 2025
Problem:  Unicode has deprecated some code-points
Solution: Update the digraph tables to align with the Unicode v16
          release (David Friant)

This commit updates the digraphs Left-Pointing Angle Bracket '</'
and Right-Pointing Angle Bracket '/>' to account for the fact that
the old Unicode codepoints for them (2329 and 232A, respectively)
have been deprecated. As per the Miscellaneous Technical code chart
(https://www.unicode.org/charts/PDF/U2300.pdf), the old digraphs
have been reassigned to the CJK Left Angle Bracket and Right Angle
Bracket (3008 and 3009) with their declaration moved to the
appropriate block.

This commit also introduces the new digraphs '<[' and ']>' to
represent the Mathematical Left Angle Bracket and Mathematical
Right Angle Bracket (27E8 and 27E9) to replace the deprecated code
points in the Technical block.

Tests have been added and, I believe, the documentation has been
updated accordingly.

closes: vim/vim#17990

vim/vim@c08b94b

Co-authored-by: David Friant <friant@HPEnvyx360.friant.dev>
zeertzjq added a commit to neovim/neovim that referenced this pull request Aug 17, 2025
Problem:  Unicode has deprecated some code-points
Solution: Update the digraph tables to align with the Unicode v16
          release (David Friant)

This commit updates the digraphs Left-Pointing Angle Bracket '</'
and Right-Pointing Angle Bracket '/>' to account for the fact that
the old Unicode codepoints for them (2329 and 232A, respectively)
have been deprecated. As per the Miscellaneous Technical code chart
(https://www.unicode.org/charts/PDF/U2300.pdf), the old digraphs
have been reassigned to the CJK Left Angle Bracket and Right Angle
Bracket (3008 and 3009) with their declaration moved to the
appropriate block.

This commit also introduces the new digraphs '<[' and ']>' to
represent the Mathematical Left Angle Bracket and Mathematical
Right Angle Bracket (27E8 and 27E9) to replace the deprecated code
points in the Technical block.

Tests have been added and, I believe, the documentation has been
updated accordingly.

closes: vim/vim#17990

vim/vim@c08b94b

Co-authored-by: David Friant <friant@HPEnvyx360.friant.dev>
mao-yining pushed a commit to mao-yining/vim that referenced this pull request Aug 18, 2025
Problem:  Unicode has deprecated some code-points
Solution: Update the digraph tables to align with the Unicode v16
          release (David Friant)

This commit updates the digraphs Left-Pointing Angle Bracket '</'
and Right-Pointing Angle Bracket '/>' to account for the fact that
the old Unicode codepoints for them (2329 and 232A, respectively)
have been deprecated. As per the Miscellaneous Technical code chart
(https://www.unicode.org/charts/PDF/U2300.pdf), the old digraphs
have been reassigned to the CJK Left Angle Bracket and Right Angle
Bracket (3008 and 3009) with their declaration moved to the
appropriate block.

This commit also introduces the new digraphs '<[' and ']>' to
represent the Mathematical Left Angle Bracket and Mathematical
Right Angle Bracket (27E8 and 27E9) to replace the deprecated code
points in the Technical block.

Tests have been added and, I believe, the documentation has been
updated accordingly.

closes: vim#17990

Signed-off-by: David Friant <friant@HPEnvyx360.friant.dev>
Signed-off-by: Christian Brabandt <cb@256bit.org>
yochem pushed a commit to yochem/neovim that referenced this pull request Aug 23, 2025
…5358)

Problem:  Unicode has deprecated some code-points
Solution: Update the digraph tables to align with the Unicode v16
          release (David Friant)

This commit updates the digraphs Left-Pointing Angle Bracket '</'
and Right-Pointing Angle Bracket '/>' to account for the fact that
the old Unicode codepoints for them (2329 and 232A, respectively)
have been deprecated. As per the Miscellaneous Technical code chart
(https://www.unicode.org/charts/PDF/U2300.pdf), the old digraphs
have been reassigned to the CJK Left Angle Bracket and Right Angle
Bracket (3008 and 3009) with their declaration moved to the
appropriate block.

This commit also introduces the new digraphs '<[' and ']>' to
represent the Mathematical Left Angle Bracket and Mathematical
Right Angle Bracket (27E8 and 27E9) to replace the deprecated code
points in the Technical block.

Tests have been added and, I believe, the documentation has been
updated accordingly.

closes: vim/vim#17990

vim/vim@c08b94b

Co-authored-by: David Friant <friant@HPEnvyx360.friant.dev>
sahinf pushed a commit to sahinf/vim that referenced this pull request Sep 7, 2025
Problem:  Unicode has deprecated some code-points
Solution: Update the digraph tables to align with the Unicode v16
          release (David Friant)

This commit updates the digraphs Left-Pointing Angle Bracket '</'
and Right-Pointing Angle Bracket '/>' to account for the fact that
the old Unicode codepoints for them (2329 and 232A, respectively)
have been deprecated. As per the Miscellaneous Technical code chart
(https://www.unicode.org/charts/PDF/U2300.pdf), the old digraphs
have been reassigned to the CJK Left Angle Bracket and Right Angle
Bracket (3008 and 3009) with their declaration moved to the
appropriate block.

This commit also introduces the new digraphs '<[' and ']>' to
represent the Mathematical Left Angle Bracket and Mathematical
Right Angle Bracket (27E8 and 27E9) to replace the deprecated code
points in the Technical block.

Tests have been added and, I believe, the documentation has been
updated accordingly.

closes: vim#17990

Signed-off-by: David Friant <friant@HPEnvyx360.friant.dev>
Signed-off-by: Christian Brabandt <cb@256bit.org>
dundargoc pushed a commit to dundargoc/neovim that referenced this pull request Sep 27, 2025
…5358)

Problem:  Unicode has deprecated some code-points
Solution: Update the digraph tables to align with the Unicode v16
          release (David Friant)

This commit updates the digraphs Left-Pointing Angle Bracket '</'
and Right-Pointing Angle Bracket '/>' to account for the fact that
the old Unicode codepoints for them (2329 and 232A, respectively)
have been deprecated. As per the Miscellaneous Technical code chart
(https://www.unicode.org/charts/PDF/U2300.pdf), the old digraphs
have been reassigned to the CJK Left Angle Bracket and Right Angle
Bracket (3008 and 3009) with their declaration moved to the
appropriate block.

This commit also introduces the new digraphs '<[' and ']>' to
represent the Mathematical Left Angle Bracket and Mathematical
Right Angle Bracket (27E8 and 27E9) to replace the deprecated code
points in the Technical block.

Tests have been added and, I believe, the documentation has been
updated accordingly.

closes: vim/vim#17990

vim/vim@c08b94b

Co-authored-by: David Friant <friant@HPEnvyx360.friant.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants