runtime(sh): Selectively suppress classes of errors - #20935
Draft
zzzyxwvut wants to merge 5 commits into
Draft
Conversation
Bash identifiers declared in scripts cannot have a leading "#" in their names. And neither "namespace" nor "function" can be followed by a newline before an identifier. Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com> Co-authored-by: Christoffer Aasted <dezzadk@gmail.com> Co-authored-by: Doug Kearns <dougkearns@gmail.com> (cherry picked from commit 0627ec0)
Claim e.g. "function f () { :; }" as shFunctionTwo while
observing that parentheses after the function name are
optional when the "function" word is used and do not delimit
its body if the latter follows them in "{}" (which should
not be taken for granted with limited backtracking).
Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com>
(cherry picked from commit 645091d)
As a refinement upon "g:sh_no_error", support suppression of only certain classes of errors. Look up syntax rule names and list them with: ‐----------------------------------------------------------- let g:sh_no_error_rules = ["shCurlyError", "shParenError"] ‐----------------------------------------------------------- Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com>
Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com>
Signed-off-by: Aliaksei Budavei <0x000c70@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a refinement upon
g:sh_no_error, support suppression ofonly certain classes of errors. Look up syntax rule names
and list them with: