Skip to content
This repository was archived by the owner on Aug 26, 2021. It is now read-only.

Release/2.1.0#162

Merged
wilrnh merged 39 commits intomasterfrom
release/2.1.0
Jun 28, 2017
Merged

Release/2.1.0#162
wilrnh merged 39 commits intomasterfrom
release/2.1.0

Conversation

@wilrnh
Copy link
Copy Markdown
Contributor

@wilrnh wilrnh commented Jun 28, 2017

Ticket

CI-522

Issue Summary

  • Merging in the release 2.1.0 branch.

Gavin King and others added 30 commits May 3, 2017 12:30
VIM-4712: Adding action sheet option to add to channel
[CRI-108] Singleton for VimeoClient
…ngleton

AF-XXX: Make Date Formatter in Object Mapper a Singleton
TVOS-732: Updated cacheKey
…PI team has enabled badge property in iOS’s json response which is required to properly handle logic to display badge if video is staff picked.
…oNetworking into tech/AF-49_research_unittests
…he base URL to use instead of always using the VimeoBaseURL defined in the Constants.swift file.
[CRI-34] Badges property on VIMVideo now required outside of TV_OS. A…
@wilrnh wilrnh requested review from ghking and jasonhawkins June 28, 2017 17:47
@cameo-github
Copy link
Copy Markdown

1 Warning
⚠️ VimeoNetworking/Sources/VimeoClient.swift#L330: cast from ‘Response<VIMNullResponse>’ to unrelated type ‘Response<ModelType>’ always fails
let response = Response(model: nullResponseObject, json: [:]) as! Response<ModelType>
1 Message
📖 Executed 46 tests, with 0 failures (0 unexpected) in 0.595 (0.623) seconds

See build details on CircleCI

Generated by 🚫 danger

Copy link
Copy Markdown
Contributor

@jasonhawkins jasonhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@ghking ghking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wilrnh wilrnh merged commit 4faa513 into master Jun 28, 2017
@wilrnh wilrnh deleted the release/2.1.0 branch June 28, 2017 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants