Add radiation polarization clock and recalc trigger - #79
Merged
Conversation
…ionCorr - Add mClockLinearPolarRate to Radiation (header + all constructors) - Click mClockLinearPolarRate in SetLinearPolarRate() and expose GetClockLinearPolarRate() accessor - Update PolarizationCorr::CalcCorr() to use the new clock instead of the fragile floating-point mPolarAfactor comparison - Wire mClockPowderPatternRadiation as a parent of mClockLinearPolarRate in PowderPattern::Init() so all component mClockMaster hierarchies are properly invalidated when the polarisation rate changes - Add unit test TestPolarizationCorrLinearPolarRateTrigger that verifies changing the linear polarisation rate causes GetPowderPatternCalc to return a different result Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Related to pyobjcryst issue #38. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- remove linear polarization clock child from mClockPowderPatternRadiation - wire PowderPatternDiffraction mClockMaster directly to Radiation::GetClockLinearPolarRate() - remove old parent wiring when parent powder pattern is replaced Related to pyobjcryst issue #38. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Revert PowderPattern.cpp updates added on this branch. Related to pyobjcryst issue #38. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- remove polarizationcorr-polar-rate-trigger unit test and runner entry - keep the PolarizationCorr clock-based invalidation change - align changelog wording with implemented behavior Related to pyobjcryst issue #38. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to pyobjcryst issue #38.